[go: up one dir, main page]

Skip to content

Reviewer should be able to give positive feedback on code sections

Problem to solve

I as a reviewer would like to give positive feedback on good code. This would increase motivation in the team and would also make clear that i appreciate some nice refactoring (or maybe the use of the boy scout rule)

For now I "only" can start a conversation which normally means there is a problem (otherwise the resolve feature don't make much sense).

I'm currently using the conversation function as a workaround to give positive feedback.

But it feels wrong, i always have to resolve it myself and then it's not longer visible in the MR overview.

Intended users

The feature should be used by all reviewers. And the MR Authors would of course see the outcome of it.

Proposal

The simplest solution could be a thumbsup button which could be placed on a line of code. (maybe with a count in case of multiple reviewers)

It could also be a textfield which is shown in green in the overview. I think it should not be a discussion and there is no need to make it "answerable".

Permissions and Security

Every Reviewer who has the permission to start a discussion should be allowed to give positive feedback.

Edited by Andreas Schnapp