Follow-up from "Surround selected text with typed backtick or single quote in markdown fields"

The following discussion from !25748 (merged) should be addressed:

• @dmishunov started a discussion:

  nitpick: @digitalmoksha whenever one italicizes text from the toolbar (by clicking I button), the markup inserted is *{text}*. So what you're doing here contradicts the established pattern. I can totally live with this because both are valid ways to italicize text and both work. Moreover, * is already taken for the bold text and we can not rely on double chars (**) here.

  So, I'm fine with this deviation from the pattern. However, I would like this thread to be resolved in a follow-up issue where we update the markup generated by markdown toolbar to _{text}_ instead of *{text}*. From what I can see, this, technically, involves two files:

  • app/views/shared/blob/_markdown_buttons.html.haml
  • app/assets/javascripts/vue_shared/components/markdown/header.vue

  What do you think about resolving this thread in a follow-up @digitalmoksha?