Add toggle to resolve all threads in a MR review workflow
Problem to solve
An idea from Twitter, new issue as suggested in &3607 (comment 366584129).
A button/toggle to resolve all threads on an MR. The story behind this could be a separate commit addressing all the discussed changes, depending on the workflow. Or, if there are numerous remarks but they all are not necessary, this comes in handy as well.
This could lean into "In a MR, "Please resolve these threads" should be a hyperlink pointing to the threads to be resolved".
Intended users
User experience goal
Imagine a merge request review workflow where N comments have been left, and all changes are applied. Instead if clicking each review thread one by one and resolve it, a global toggle with "resolve all threads" helps speed this up.
Proposal
Add a new toggle into the UI which fires the action in the background. It may need an additional API action to avoid multiple requests and do this in a single transaction.
Further details
Should this only apply to new comments or everything? A discussion point is to avoid "abuse" of this feature, where discussions are just turned down in order to merge the MR more quickly.
Before adding a PoC, I'd suggest a discussion/feedback on the matter.
Permissions and Security
Applies to owner, maintainer and developer only.
Documentation
- Requires a docs section & screenshots for usage.
- Requires permission documentation.
Availability & Testing
Tests need to ensure that all threads are resolved, nothing is left, and MR can be merged then (if the requirement is enabled in project settings).
What does success look like, and how can we measure that?
- Saved cycles in MR reviews.
- Users sharing this feature on social.
What is the type of buyer?
This should be available for everyone, Core and Enterprise. Reason: This improves the MR review workflow and helps developers, similar to batch review comments now also moved to Core with 13.1. Adding this completes the workflow.