[go: up one dir, main page]

Skip to content

Diff view in discussions doesn't clearly show which line of code is being referred to in the comment

It's not clear to what line the comment in the diff view is referring to (in discussions). After asking around I realized it was the last line included in the diff view but I think that should be clearer. I tried to follow a long discussion with lots of diff views and comments on them and found it really hard. These little details that I haven't learned about yet make it harder for me to understand the interface, I imagine other users experience similar issues.

Current:

image

Line 38 is the one Dimitrie is referring to in his comment.

Design

  • Introduce similar avatar/comment indicators as the image diff commenting feature
  • Starter of the discussion thread will get the blue dot attached to its avatar, which is also represented on the diff line for which the thread is started

Group

Note: Don't mind the numbering of the lines in the mockup, they are displayed a bit strangely due to mockup artifacts! Nothing should change in their logic, this feature would just add the icons to indicate the ref line.

Edited by Dimitrie Hoekstra