[go: up one dir, main page]

Skip to content

Require confirmation when clicking green "Merge" button and the merger is not the MR creator

Problem to solve

As a gitlab user, I want a confirmation dialogue to pop up when I click the big green "Merge" button if the merge was not created by myself, so that I can be sure I really want to merge that.

It has happened to many people at my company that they click the "Merge" button on someone else's MR by mistake, and are then embarrassed and have to go undo the merge, or check with the owner that it was OK.

Intended users

All, especially developers.

User experience goal

To be very clear that the Merge click is intended to merge someone else's MR.

Proposal

If the MR creator is not the current user, it would suffice to include a javascript confirm("Do you really want to merge $developer's work?")

Further details

Permissions and Security

No special permissions, just a speedbump to stop people from stupidly clicking something they did not mean to.

Documentation

Availability & Testing

There may be an extra step in testing Merge button usage.

What does success look like, and how can we measure that?

Success is requiring an extra click to merge someone else's work.

What is the type of buyer?

All tiers.

Is this a cross-stage feature?

Links / references