[go: up one dir, main page]

Skip to content

Include `review_id` for Notes on API responses

I was working on a tool that fetches Notes from Merge Requests, and I've noticed that the notes wouldn't include the review_id when created through a MR Review, even though the data is there [1] [2].

I'd like to be able to "re-group" those notes as one "review", but I couldn't find any attribute that would make that possible.

Would you be open to a MR that includes the review_id on the Note json [3]? Probably an easy code change plus updating the docs.

[1] https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/services/draft_notes/publish_service.rb#L32-37

[2] https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/structure.sql#L4155

[3] https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/serializers/note_entity.rb