[go: up one dir, main page]

Skip to content

Fix the "two button submit" on the MR when completing multiple points of feedback

Problem to solve

During a live coding session, @sytses ran into an issue with the two green buttons that appear when you resolve a group of comments. See video: https://youtu.be/ymUqM82wj6Y?t=375

Intended users

Who will use this feature? If known, include any of the following: types of users (e.g. Developer), personas, or specific company roles (e.g. Release Manager). It's okay to write "Unknown" and fill this field in later.

Further details

Proposal

  1. Rename Finish review to Submit review: And make it submit the review immediately, instead of showing the list of pending comments.
  2. Move the “list of pending comments” into its own button: The split button should be for alternative actions. Viewing the list of pending comments is not an alternative to Submit. We can have a Pending comments button just for that, showing the list like we do today.
    1. As a consequence of the two previous points, remove the Submit review button at the bottom the list of pending comments.
  3. Remove the Discard review button: How often do people “Discard” a review? It can be helpful, but how often does it make sense to completely delete an entire review? We still have the alternative solution of deleting the individual comments. Having this button here thus only makes the absolute worst case slightly less painful, and we will have to take it into account again when we think about the future iteration with an additional textbox.

image

Permissions and Security

Documentation

Availability & Testing

What does success look like, and how can we measure that?

What is the type of buyer?

Is this a cross-stage feature?

Links / references

Edited by Pedro Moreira da Silva