[go: up one dir, main page]

HTML tag <br> in custom hook error output

Summary

New lines in custom hook error output are correctly subsituted with <br> tag, but <br> is shown as raw html in output.

Steps to reproduce

  • create custom update hook with multiline output
  • let the hook fail:
#!/bin/bash
echo "line 1"
echo "line 2"
exit 1

What is the current bug behavior?

<br> tags are shown in hook output

What is the expected correct behavior?

new lines should be wrapped appropriately

Relevant logs and/or screenshots

mr-hook-error

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:		Debian 8.10
Current User:	git
Using RVM:	no
Ruby Version:	2.3.6p384
Gem Version:	2.6.13
Bundler Version:1.13.7
Rake Version:	12.3.0
Redis Version:	3.2.11
Git Version:	2.14.3
Sidekiq Version:5.0.5
Go Version:	unknown


GitLab information
Version:	10.4.1
Revision:	be80a97
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	postgresql
URL:		https://[censored]
HTTP Clone URL:	https://[censored]/some-group/some-project.git
SSH Clone URL:	git@[censored]:some-group/some-project.git
Using LDAP:	no
Using Omniauth:	no


GitLab Shell
Version:	5.11.0
Repository storage paths:
  • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Edited by Roman Pavlík