[go: up one dir, main page]

Skip to content

Add option to prevent merge request approval by users who authored any commits in the merge request

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Problem to solve

GitLab already offers a way to prevent merge request approvals by users who have pushed commits to the merge request, or the user who has opened the merge request

Screenshot_from_2020-02-21_16-58-58

What's missing here for me is the ability to prevent approvals by users who are authors (rather than committers) of any of the commits pushed to the merge request. As an example, let's say I cherry-pick commits by user A, and then open a merge request. GitLab offers the option to prevent me, and any users that have pushed commits to the merge requests from approving the MR, but it doesn't offer an option to prevent A from approving the MR.

I'm proposing to add this option. For me, in a case like this, it doesn't matter who committed the patch, rather, what matters is who authored the patch (as an extreme case imagine a scenario where all commits in the MR are by user A - it doesn't seem right that A should be able to approve such a request).

As far as I remember, this used to be the default, but it changed with a recent update.

Edited by 🤖 GitLab Bot 🤖