[go: up one dir, main page]

Skip to content

'Hide whitespace changes', 'Inline' and 'Side-by-side' not available in merge request diff view on mobile website

Description

On the code diff page of merge requests on the desktop version of gitlab, there is a button to hide whitespace changes which comes in very handy when viewing changes which come with a large amount of whitespace changes (due to the editor configuration to apply reformatting) that hide the actual code change.

2017-12-22-104329_1137x618_scrot

While probably no full code review will happen on a mobil device, I miss this feature on the mobile version of the webpage. NB: On a small screen / in a small window, concentrating on the relevant changes is even more crucial as one doesn't have such a good overview as on the big screen.

Screenshot_20171222-104214

A random example from gitlab.com where the hide whitespaces button is not visible on a mobile device is here.

I do realise that most mobile device browsers can request the desktop page, but I think that undermines the effort that went into the mobile version of the page and defeats its entire purpose. Also, in the general page layout I like the mobile version of the page (for mobile devices).

Proposal

The space to add such a button is limited on the small screen, but I guess "about where it is on the desktop version" is probably best. The option to switch between inline and side-by-side will likely not work out, so these two buttons can be omitted.

Links / references

PS: yes, there are no whitespace changes either on the screenshot merge request nor on the one I linked, I hope it suffices that the existence of the button is demonstrated.

Edited by Mark Fletcher