[go: up one dir, main page]
Skip to content

Add a quick action to open a issue from a merge request

Description

Sometime an MR is good enough to be merged, but during the review an unrelated task my be highlighted. One can open a discussion and later use the "Resolve in a new issue" button, but doing that the review flow is lost because the new issue page is opened to fill the details.

Proposal

Add a /issue quick action to open a new issue from an MR comment, pointing back to the file context (with no user interaction).

Documentation blurb

/issue «some description» to open a new issue titled "Follow-up from "MR title like now" «some description»"

  • maybe use some @user or ~label to do some other magic.

Overview

  • What is it?: a new quick action
  • Why should someone use this feature?: to mark some work to be done for later
  • What is the underlying (business) problem?: slow merges and code quality
  • How do you use this feature?: opening a new issue during a review without leaving the review page.

Use cases

Mary is doing a code review for the feature X.

She noted that the utility function rewrap_text near the modified code is implemented in a very similar way in another branch she just reviewed.

That code is not related to the X feature, so there it is not optimal to slow the MR for that, but nonetheless the code is duplicated.

She should write a comment, press the "Resolve in a new issue", leave the review page and fill a issue details. And than go back to the MR and scroll back to the exact point she was (the automatic link points to the Discussion page, not to the Changes one, and may be OK that way).

A /issue quick action can do much of the work automatically and not break the review process.

Feature checklist

Make sure these are completed before closing the issue, with a link to the relevant commit.

Edited by Matteo Bertini