[go: up one dir, main page]
Skip to content

Commit comments for a merge request should be resolvable discussions

Description

This is a follow-up issue for gitlab-ce#31847 after gitlab-ce!12148 is merged. This should be done after gitlab-ce#40047

When we create a commit comment in the context of a merge request, we should be able to create a discussion that needs to be resolved before the merge request can be merged.

Proposal

The current page has a "Start discussion" button that can be used, but this type of discussion is not resolvable.

Links / references

Documentation blurb

Overview

What is it?

Why should someone use this feature? This is to support per-commit review workflows.

What is the underlying (business) problem? We can add discussion on a commit, that will show up

How do you use this feature?

Open a merge request
  Commits tab -> click a commit
    Commit page (with merge_request context) -> click View details
      Start a discussion on the commit (not on a diff)

Use cases

Who is this for? Provide one or more use cases. See gitlab-ce#39380, gitlab-ce#35287

This could be use to comment on a commit's metadata, like the commit message or length and block the merge request from being merged if the comment is not resolved.

Feature checklist

Make sure these are completed before closing the issue, with a link to the relevant commit.

Edited by Micaël Bergeron