[go: up one dir, main page]

Skip to content

Image discussion: Comment form is auto-focused after adding a comment marker

Summary

I love the new image discussion feature that was added with 10.1!

I have a minor UX feedback regarding adding of image comments. When I add a new comment on a certain coordination, the comment markdown form is focused by default. This results in a jump of the scrolling position, especially on smaller screens. If I want to check the position of my just created image marker or want to change it, I have to scroll back to the image. To me, this behavior is rather disruptive.

It might be a technical restriction to bind image marker and comment. Thank you for considering this input!

Steps to reproduce

  • Open Merge request changes or Commit view with image
  • Add a new image comment icon

Example Project

See New example image (!2) · Merge Requests · Andreas Kämmerle / example-project · GitLab on GitLab.com for an example.

What is the current behavior?

  • When I add a new image comment marker, the markdown comment container is focused.

What is the expected behavior?

  • Markdown comment container should not be focused to see the result and position of my added marker

Thanks!

Edited by Andreas Kämmerle