Follow-up from "Draft: Return early if user is nil in ee/lib/ee/gitlab/auth/saml/user.rb"
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
The following discussions from !50216 (merged) should be addressed:
-
@bmiller1 started a discussion: (+5 comments) Unsure if this MR meets the criteria to at-mention gitlab-com/gl-security/appsec. Please advise.
-
@bmiller1 started a discussion: (+5 comments) Good catch @lmcandrew. I missed that completely.
I would like to see us catch this case further up the stack but I am still learning my way around the code flow. Moving it up too far and the reader loses the temporal context of the test.
Do you have any recommendations as to a good point, both logially and contextually, to perform the test?
Edited by 🤖 GitLab Bot 🤖