Remove deprecated function trimFirstCharOfLineContent from diffs/store/utils.js

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

This function is deprecated due to its very limited utility and its undocumented mutation side effect.

Most places that use this particular function have already been updated, but it remains used by the Notes app.

For further context, please note this original discussion where I deprecated the function.

The best course of action here is likely to update the Notes app to have the same - more straightforward - behavior from the Diffs app. In short, this uses a much simpler (one line) function to actually perform the string replacement, and manually performs what had been the side effect of delete ing the .text property.