[go: up one dir, main page]

Skip to content

Use merge request ID and merge request title in the URL and resulting file name for patches

Problem to solve

Let's take an arbitrary merge request as an example:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29900

If I decide to apply the changes there, but not merge that request per se - for reasons; maybe it's just git that doesn't like me an annoys me with a merge conflict - then I can go the traditional patch route and just apple the patch I get from here:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29900.patch

All fine, except for the patch file name - it's only the merge request ID. If you got multiples, this might be a bit hard to tell apart.

Intended users

Anyone who needs to apply a merge request via the corresponding patch, for reasons.

Further details

Proposal

It would be better if it was a combination of the ID and the merge request title (or the email patch's subject), as in e.g.

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29900-Fixed-failing-GraphQL-file-import.patch

Permissions and Security

Nothing special, I'd say.

Documentation

Testing

URL and file name filtering of titles will have to be done.

What does success look like, and how can we measure that?

Patch URLS include the title/subject, and files saved from there will be named e.g. 29900-Fixed-failing-GraphQL-file-import.patch

It would also be nice if https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29900.patch was a redirect to the ID+title.patch URL.

Links / references

Edited by Michael Schumacher