[go: up one dir, main page]

Skip to content

"Apply Suggestion" button always adds an extra commit; offer an option to amend to a previous commit

Problem to solve

When you click the "Apply Suggestion" button for a suggested change, it adds a new commit to the merge request.

This is not a problem if the merge request will be squash-merged. But in case the MR has a curated commit history, the new commit must be manually amended into one of the existing commits which wastes time. If you want to apply many suggestions, the MR will wind up with many extra commits and the manual work required is quite annoying, especially if the suggestions logically apply to different commits in the MR.

Intended users

Developers

User experience goal

Make the "Apply Suggestion" feature usable for Merge Requests with a curated commit history that will be not be squash-merged

Proposal

It would be much nicer if you could specify a commit in the MR to amend the applied suggestion into. This would be a huge time safer and quality of life improvement.