[go: up one dir, main page]

Skip to content

Allow filter to apply to both the file list and the file diffs when reviewing the diffs in a merge request

Problem to solve

When reviewing an MR, I often use the filter text box to limit the list of files shown in a diff. This is particularly useful if I'm only reviewing the gitlab-ce~3412464 portion of an MR - I can limit my review by filtering on vue or js or scss, for example.

However, this filter only applies to the file list not the diffs themselves. Even if I filter the file list down to a single file, all of the diffs are still shown:

Screen_Shot_2019-05-30_at_9.51.06_AM

It would be nice if this filter applied to the file diffs as well.

Intended users

gitlab-ce~9335216

Proposal

Filter both the file list and the diffs based on the filter text.

Links / references