[go: up one dir, main page]

Skip to content

Projects Commit Show page alert is not contained in layout

Issue

Flash alerts on the Project Commit show page stretch the entire width of the screen instead of being limited to the container of the commit data. Also related to the width is that the alerts on this page are "sticky" when they probably do not need to be - see comments here !44308 (comment 435277039)

Screenshot

Actual

image

Expected

image

follow up from issue info

The following discussion from !44308 (merged) should be addressed:

/gitlab/app/views/projects/commit/show.html.haml uses layouts described here:

  • /layout/project.html.haml which calls
  • /layout/application.html.haml which calls
  • /layout/_page.html.haml

The container enclosing the alert should be handled at the /layout/_page.html.haml but commits seems to be trying to add another layer of containers (fluid vs fixed) inside of its own file /gitlab/app/views/projects/commit/show.html.haml

Edited by Terri Chu