[go: up one dir, main page]

Skip to content

CountableConnection may need to take preloaded relations into account explicitly

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

I suspect that CountableConnection is not being smart enough to make use of preloaded relations.

We unconditionally call reorder(nil) on all relations, but if they are loaded, this will throw away the benefit of the preload.

This was identified in a discussion on !43423 (merged):

  • @alexkalderimis started a discussion: (+5 comments)

    Did you consider using app/graphql/types/countable_connection_type.rb instead? What would be the downsides of that for your use-case?

Edited by 🤖 GitLab Bot 🤖