[go: up one dir, main page]

Resetting approvals on push for GitLab Core

Release notes

Problem to solve

Since GitLab Core supports (optional) approvals, it would make sense to also add "Remove all approvals in a merge request when new commits are pushed to its source branch" setting.

Intended users

Development Team Lead, Compliance Manager

User experience goal

Any changes on a Merge Request already approved should reset the approvals, even if the approval is optional

Proposal

Promote the "Resetting approvals on push" configuration setting to Core.

Screen_Shot_2021-04-15_at_11.52.26

Further details

This aligns with the concept of optional approval in Core: "This provides a consistent mechanism for reviewers to approve merge requests, and ensures maintainers know a change is ready to merge."

Permissions and Security

Documentation

Documentation is already up-to-date: https://docs.gitlab.com/ce/user/project/merge_requests/merge_request_approvals.html#resetting-approvals-on-push.

Availability & Testing

What does success look like, and how can we measure that?

What is the type of buyer?

Is this a cross-stage feature?

Links / references

Edited by Florent Monbillard