Refactor Reviewers & Assignees Vue Components
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
The reviewers
code implementation is based on assignees
. So make sure to apply these improvements on BOTH reviewers
and assignees
for consistency
Changes
The following discussion from !40926 (merged) should be addressed:
-
@iamphill started a discussion: Does
gl-button
work here?🤔
The following discussion from !40926 (merged) should be addressed:
-
@iamphill started a discussion: Does this need to be a computed prop? No value inside changes so it could either be on
$options
or inside the template right?
The following discussion from !40926 (merged) should be addressed:
-
@iamphill started a discussion: I know this is copying what exists for assignees - but would it be possible to see if
GlIcon
could work instead?
The following discussion from !40926 (merged) should be addressed:
-
@iamphill started a discussion: Can this
v-if
be place on the<span>
on the line below?🤷
The following discussion from !40926 (merged) should be addressed:
-
@iamphill started a discussion: Worth moving this to below the
if
?🤷 Also where does apollo get used in the reviewers?
🤔