[go: up one dir, main page]

Skip to content

Take resolved threads from the pending review into consideration for the unresolved threads count section

Release notes

Problem to solve

As a MR reviewer, I want for comments that resolve threads added to the current review to be reflected in the "unresolved threads" count, so I can track them easier, without having to submit the review before it's finished.

Intended users

Developer

User experience goal

The user should be able to know the exact number of unresolved threads, even if some of the threads will be resolved by some comments in the currently pending review.

Proposal

  • Open a MR
  • Leave a comment (the "1 unresolved thread" text will be shown)
  • Type a reply
  • Check the "Resolve thread" option
  • Start a review
  • The unresolved threads count section would be updated to say "All threads resolved"

Further details

Currently, if there are multiple threads, it's hard to filter the unresolved ones, until you submit the review.

Permissions and Security

Documentation

Availability & Testing

What does success look like, and how can we measure that?

What is the type of buyer?

Is this a cross-stage feature?

Links / references

Edited by Iulian Onofrei