[go: up one dir, main page]

Skip to content

View people who have approved merge request

Resources

PM @victorwu | UX @hazelyang

Description

  • We want to support the unapprove merge request feature (#894 (closed)). The first step is to re-design the existing approvals interface to support #894 (closed) to and allow future (#761 (closed)) to be created with a clean design.
  • The net new functionality for this issue is viewing who has already approved a merge request. (This does not currently exist.)
  • This merge request for this issue should only contain this issue and no other scope.

Out of scope

  • Removing an approval is not part of this issue.

Design and mockups

  • View who has already approved a merge request with the profile pictures with checkmark icon in the top-right corner.
  • Tooltip on the profile icons and link to those people, similar to the sidebar.
  • View how many remaining approvals are required with the dotted circles.

Screenshot_2016-11-17_at_19.17.44

Edited by Coung Ngo