[go: up one dir, main page]

Skip to content

Merge requests should record and display read / unread status for all files

Problem to solve

The merge request UI does not show the read/unread status for files. This makes it very hard to see where you left off on code reviews.

Intended users

Developers

Further details

Both Fisheye and Upsource support read/unread status so that code reviewers are able to see which files they have not yet read.

Proposal

Record read/unread status for each file for each user on a merge request. This status should be shown in the UI to the reviewer.

One possibility is to have file names show up in bold if they have unread changes. This is how Upsource implements the feature. In the screenshot below you can see that only the SaleCalculator.java and pom.xml files have been read by the reviewer: image

Fisheye does the same thing, bolding the filenames that have not been read by the reviewer. It goes a step further though and allows users to configure exactly when the file is marked as read and allows users to manually unmark a file as having been read: https://confluence.atlassian.com/crucible/using-progress-tracking-298977446.html

Permissions and Security

No major security changes.

Documentation

Needed.

Testing

Ensuring that new commits that come into a merge request reset the read status on files changed in the new commit.

What does success look like, and how can we measure that?

Developers are able to see which files in a merge request they have already read.

What is the type of buyer?

Starter

Links / references

Edited by Tyler Yates