[go: up one dir, main page]

Fix MR approval rule regenerated list of members with hidden group

The following discussion from !10056 (merged) should be addressed:

  • @pslaughter started a discussion: (+1 comment)

    issue: When editing MR approval rules that have private groups, the list of approvers is regenerated from the FE, but naturally excludes the private groups. This causes some weird behavior and makes it look like members have been removed.

    20190319_private_groups_approval_issue_mr_edit

    What are the options?

    I think we should expose an endpoint GET rule/{id}/members?group_ids=&user_ids= which will return the list of members if that rule is updated with the given group ids and user ids. WDYT?