Flash messages on MR widget telling me to Try Again
On MR page, we show flash messages for CI Environment status failures, Notes failures, and MR endpoint failures. Since they are polling it doesn't mnake sense to show an error message, especially one that says "please try again"
Reproduce
- Load MR page
- Disconnect internet
- Fresh error messages every few seconds
Message examples:
Unclear: "Something went wrong. Please try again." Unnecessary: "Something went wrong while fetching the environments for this merge request. Please try again."
Proposal
Don't show flash messages from MR widget fetch failures
Sidenote: I have been having some doubts about the "always catch or return" eslint rule, since it has typically resulted in worse things than Promises eating errors.
We typically do one of:
- empty catch block with either a comment or something to silence lint. This is worse than having no catch (since error is untraceable)
- catch block that Flashes generic error