[go: up one dir, main page]

Skip to content

Incomplete checklists in merge request should block approval

Description

As requested by customer:

I'd like to define a checklist for merge requests that an approver has to go through and check off before being able to approve a merge request.

Proposal

Enforce all checklists tasks are complete before allowing Merge Request approval.

Note: We have proposed the following workarounds but none of these meet the customers requirements.
  1. Create a default Merge Request template with a checklist created in Markdown. This way, all new Merge Requests include the checklist.

  2. Consider adding dedicated Merge Request Approvers who must approve the MR before it can be merged, and they can verify the checklist.

  3. Custom git hooks

  4. Disable merge requests unless discussions are resolved followed by adding the tasklist to a new discussion.

Links / references

ZD: https://gitlab.zendesk.com/agent/tickets/83482

Documentation blurb

Only allow merge request approval once all items in checklist have been completed.

Overview

What is it?

Prohibit merge request approval until all checklist items are complete.

Why should someone use this feature?

To ensure workflow is consistent

What is the underlying (business) problem?

Merge requests being approved without all items being actioned.

How do you use this feature?

Option box in Project Settings.

Use cases

Applicable to any customer who wants to enforce checklist completion.

Feature checklist

Make sure these are completed before closing the issue, with a link to the relevant commit.