[go: up one dir, main page]

Skip to content

Line-by-line review

Approve diffs line-by-line.

I'm not a maintainer so I'm not experienced with reviewing, thus don't know the good and bad practises of providing a review. But, the first point of our review docs is...

Try to be thorough in your reviews to reduce the number of iterations.

So, it may be interesting to be able to "approve" a diff line-by-line for example...

Screen_Shot_2017-04-15_at_17.20.07

On this MR diff, lines 1 , 75 , 76 , 77 , 77 , 78 , 79 , 80 , 81 would have some sort of UI that a reviewer (maybe all suggested or selected approvers? 🤔) could accept () or reject () each line. When a commit is pushed and a line changes, it will reset. This would let you easily see which lines exactly changed since your last review.

I'm not too sure on the "reject" action as this could be more useful for tracking where you are in your review than a method of acceptance, but maybe it could be useful for some flows.