[go: up one dir, main page]

Skip to content

Consider adding a conditional rule for file folding in merge requests review process

Description

We all know good MR should be small, but reality is brutal and quite often merge requests come with lots of code, which is potentially irrelevant for the reviewer but necessary for the build. Gitlab already folds some file diffs for huge MRs, but sometimes this is not enough and is too random. Loading huge diffs (changes section in the MR) takes lots of time, and makes the process of reviewing painful.

It would be great, if there was an option to specify a rule, by which the files are folded in the MR. This would allow the reviewer to see the most important changes first, and then if required/relevant see the rest by unfolding the particular files. The rule would obviously vary based on the nature of the project or language.

My personal problem is reviewing golang code, which includes changes with the updated vendor directories. Sb makes a small change and is required to update some dependencies, which in go are placed under the vendor directory. Obviously this can be handled, by restricting the process of committing to and reviewing MR, but sometimes this is simply big pain :(

Proposal

Consider adding an option to Merge Requests to specify a condition (Regex?), which would define a folding rule for the files included in the MR and the diffs. The cool part is that, this would not take away anything from reviewers, all files would be still available, but folded, based to organization/project agreed rules.

Links / references

Not sure if relevant, but if needed I can provide some links that explain the go project structure, which includes committed vendor directory