[go: up one dir, main page]
Skip to content

Restrict individual approvers to project members or group members

Resources

FE @psimyn

Docs blurb

To simplify assigning approvers, the search is now limited to project members for individual approvers

Description

  • Restrict the individual approvers in the approvers search box to be only project members or parent group members.
  • If @victorwu is a member of the group that is the parent of this project, then @victorwu should show up in the search box.
  • If @victorwu is a member of a group that already has access to to this project via a share (i.e. https://gitlab.com/gitlab-org/gitlab-ee/issues/2048), then @victorwu should show up in the search box. Note that this issue doesn't restrict the groups in the search box. That is handled in #2048.
  • If @victorwu is member of the project (added to the project explicitly), then @victorwu can show up in the search box.
  • No other GitLab instance users can show up in the search box.
  • This issue does not apply to groups that appear in the search box. Those are handled in https://gitlab.com/gitlab-org/gitlab-ee/issues/2048. That means if there is a group called some-other-group that contains users not in the project or parent group, those groups may or may not show up in the search box. That restriction is handled in #2048.
  • This applies to both the project settings and the per merge request settings.

Original proposal

When creating an MR the dropdown that you can use to search for approvers seems to include all users. This is not only bad for the UX (why would I want to have some random user review my MR?), but also for performance.