[go: up one dir, main page]

Skip to content

Enhance the GitLab VSCode Fork build system to generate correct packages for each platform

Follow up on the recent conversation here, gitlab-build-images!905 (comment 2385172464).

When we try to build and test workspace tools image with platform linux/arm64 (used to be using linux/amd64 only). Then the web ide package for linux/arm64 contains binary architcture for x86-64 for some dependencies, which makes the image not working properly with ARM tools image.

Example build, https://gitlab.com/gitlab-org/gitlab-web-ide-vscode-fork/-/packages/26288285, vscode-reh-web-linux-arm64-1.89.1-1.0.0-dev-20240612072203.tar.gz

~ pwd
/Users/zhaochen.li/Downloads/vscode-reh-web-linux-arm64-1.89.1-1.0.0-dev-20240612072203/node_modules/node-pty/build/Release

~ file pty.node
pty.node: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=3693da32546402c1ac25575130e7ade52d08de1a, not stripped

The current thoughts are we build each build with its own image, and make release all together. For example, linux/arm64 image base for vscode fork linux/arm64 build etc.

And the base image will be built in gitlan-build-images.

Edited by zli