From 54dc308ffafe57909857b1445f8f16ecdf517d8b Mon Sep 17 00:00:00 2001
From: Vanessa Otto <votto@gitlab.com>
Date: Fri, 8 Nov 2024 15:53:24 +0100
Subject: [PATCH] feat(Bootstrap): Remove color variable settings in
 _reboot.scss

---
 src/scss/typography.scss               |  6 ++++++
 src/vendor/bootstrap/scss/_reboot.scss | 10 +---------
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/src/scss/typography.scss b/src/scss/typography.scss
index 81ea0185a3..e69559a048 100644
--- a/src/scss/typography.scss
+++ b/src/scss/typography.scss
@@ -2,3 +2,9 @@ h1, h2, h3, h4, h5, h6,
 .h1, .h2, .h3, .h4, .h5, .h6 {
   @apply gl-text-heading;
 }
+
+// Setting colors on real anchors with an href,
+// but not on placeholder links/named anchors (without href).
+a:is([href]) {
+  @apply gl-text-link gl-no-underline hover:gl-text-link hover:gl-underline;
+}
diff --git a/src/vendor/bootstrap/scss/_reboot.scss b/src/vendor/bootstrap/scss/_reboot.scss
index cd93bfe240..c6f6212aed 100644
--- a/src/vendor/bootstrap/scss/_reboot.scss
+++ b/src/vendor/bootstrap/scss/_reboot.scss
@@ -39,8 +39,7 @@ article, aside, figcaption, figure, footer, header, hgroup, main, nav, section {
 // Body
 //
 // 1. Remove the margin in all browsers.
-// 2. As a best practice, apply a default `background-color`.
-// 3. Set an explicit initial text-align value so that we can later use
+// 1. Set an explicit initial text-align value so that we can later use
 //    the `inherit` value on things like `<th>` elements.
 
 body {
@@ -49,9 +48,7 @@ body {
   @include font-size($font-size-base);
   font-weight: $font-weight-base;
   line-height: $line-height-base;
-  color: $body-color;
   text-align: left; // 3
-  background-color: $body-bg; // 2
 }
 
 // Future-proof rule: in browsers that support :focus-visible, suppress the focus outline
@@ -184,12 +181,9 @@ sup { top: -.5em; }
 //
 
 a {
-  color: $link-color;
   text-decoration: $link-decoration;
-  background-color: transparent; // Remove the gray background on active links in IE 10.
 
   @include hover() {
-    color: $link-hover-color;
     text-decoration: $link-hover-decoration;
   }
 }
@@ -200,11 +194,9 @@ a {
 // See https://github.com/twbs/bootstrap/issues/19402
 
 a:not([href]):not([class]) {
-  color: inherit;
   text-decoration: none;
 
   @include hover() {
-    color: inherit;
     text-decoration: none;
   }
 }
-- 
GitLab