From 1ffddfb3b0fe6b1ab9fc5435009c8f95d6c92364 Mon Sep 17 00:00:00 2001
From: Grace <gcw.chung@gmail.com>
Date: Tue, 26 Mar 2024 15:04:10 -0700
Subject: [PATCH 1/3] test(nav): add a11y test for GlNav component

---
 cypress/e2e/nav.cy.js | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 cypress/e2e/nav.cy.js

diff --git a/cypress/e2e/nav.cy.js b/cypress/e2e/nav.cy.js
new file mode 100644
index 0000000000..ca2868a989
--- /dev/null
+++ b/cypress/e2e/nav.cy.js
@@ -0,0 +1,12 @@
+describe('GlNav', () => {
+  function checkA11yNavWithDropdownItem() {
+    cy.visitStory('base/nav');
+    cy.contains('Dropdown').click();
+  }
+
+  it('passes axe accessibility audits', { tags: '@a11y' }, () => {
+    cy.glRunA11yTests({
+      checkA11yNavWithDropdownItem,
+    });
+  });
+});
-- 
GitLab


From 1d28e2d191eed24e603ffe6087d22820fccc0869 Mon Sep 17 00:00:00 2001
From: Grace <gcw.chung@gmail.com>
Date: Tue, 26 Mar 2024 16:14:12 -0700
Subject: [PATCH 2/3] fix: add text for nav dropdown item

---
 src/components/base/nav/nav.stories.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/components/base/nav/nav.stories.js b/src/components/base/nav/nav.stories.js
index c664d5c435..0993f8110a 100644
--- a/src/components/base/nav/nav.stories.js
+++ b/src/components/base/nav/nav.stories.js
@@ -29,6 +29,7 @@ export const Default = (_args, { argTypes }) => ({
         <gl-nav-item-dropdown text="Dropdown">
           <template #button-content>
             <gl-icon name="question" />
+            Text
             <gl-icon name="chevron-down" />
           </template>
           <gl-dropdown-item>One</gl-dropdown-item>
-- 
GitLab


From 7602f3903947a3164532a641d9d2de5ed5b86843 Mon Sep 17 00:00:00 2001
From: Grace <gcw.chung@gmail.com>
Date: Fri, 29 Mar 2024 14:45:01 -0700
Subject: [PATCH 3/3] fix: add nav link text default and hover colors

---
 src/components/base/nav/nav.scss | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/components/base/nav/nav.scss b/src/components/base/nav/nav.scss
index 7c7bb66b8a..36accd22a2 100644
--- a/src/components/base/nav/nav.scss
+++ b/src/components/base/nav/nav.scss
@@ -1,5 +1,11 @@
 .nav {
   &-link {
+    @include gl-text-blue-500;
+
+    &:hover {
+      @include gl-text-blue-700;
+    }
+
     &:focus-visible {
       @include gl-focus;
     }
-- 
GitLab