From 7d738d09ac25595d2a461bf3193b2ff21db83156 Mon Sep 17 00:00:00 2001 From: Dimitrie Hoekstra Date: Wed, 5 Feb 2020 15:31:07 +0000 Subject: [PATCH 1/3] docs: add feedback loop modal banner Add feedback modal banner in docs to describe that the buttons need to align with the design system before we can give the component a follows design system true check. --- src/components/base/modal/modal.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/components/base/modal/modal.md b/src/components/base/modal/modal.md index f94ba68ae5..c51522e5af 100644 --- a/src/components/base/modal/modal.md +++ b/src/components/base/modal/modal.md @@ -1,3 +1,5 @@ +> Note: For this component to align with the design system specs the subcomponent [``] still needs to be replaced with [``]. [#20229](https://gitlab.com/gitlab-org/gitlab/issues/202209) tracks this effort. + # Modal -- GitLab From 81a701182b616b6e963da81e6ccc2bb448cac4b3 Mon Sep 17 00:00:00 2001 From: pburdette Date: Wed, 4 Mar 2020 08:56:57 -0500 Subject: [PATCH 2/3] docs: adjust modal doc copy Change the note on the modal documenation to make a little more sense what it means. --- src/components/base/modal/modal.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/base/modal/modal.md b/src/components/base/modal/modal.md index c51522e5af..ce14a6165c 100644 --- a/src/components/base/modal/modal.md +++ b/src/components/base/modal/modal.md @@ -1,4 +1,4 @@ -> Note: For this component to align with the design system specs the subcomponent [``] still needs to be replaced with [``]. [#20229](https://gitlab.com/gitlab-org/gitlab/issues/202209) tracks this effort. +> Note: For this component to align with the design system specs all changes made in [``] need to be merged in [``]. [#20229](https://gitlab.com/gitlab-org/gitlab/issues/202209) tracks this effort. # Modal -- GitLab From ceed79f9b172785b1c1448a998e46dbc854a1484 Mon Sep 17 00:00:00 2001 From: Tim Zallmann Date: Wed, 4 Mar 2020 14:15:38 +0000 Subject: [PATCH 3/3] Updated the note on modal --- src/components/base/modal/modal.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/base/modal/modal.md b/src/components/base/modal/modal.md index ce14a6165c..197233e71f 100644 --- a/src/components/base/modal/modal.md +++ b/src/components/base/modal/modal.md @@ -1,4 +1,4 @@ -> Note: For this component to align with the design system specs all changes made in [``] need to be merged in [``]. [#20229](https://gitlab.com/gitlab-org/gitlab/issues/202209) tracks this effort. +> Note: For this component to align with the design system specs, all changes made in [``] need to be merged into [`gl-button`]. [#20229](https://gitlab.com/gitlab-org/gitlab/issues/202209) tracks this effort. # Modal -- GitLab