[go: up one dir, main page]

GlFilteredSearch spec triggers lots of portal-vue warnings

If you run the src/components/base/filtered_search/filtered_search.spec.js spec, Jest's output is dominated by console warnings from portal-vue, like this:

  console.warn                                                                                   
    [portal-vue]: Target filters_portal_36 already exists                                        
                                                                                                 
      at VueComponent.registerTarget (node_modules/portal-vue/dist/portal-vue.umd.js:164:19)     
      at VueComponent.<anonymous> (node_modules/portal-vue/dist/portal-vue.umd.js:365:18)        
      at Array.<anonymous> (node_modules/vue/dist/vue.runtime.common.dev.js:1976:12)             
      at flushCallbacks (node_modules/vue/dist/vue.runtime.common.dev.js:1902:14)                
                                                                                                 
  console.warn                                                                                   
    [portal-vue]: Target filters_portal_37 already exists                                        
                                                                                                 
      at VueComponent.registerTarget (node_modules/portal-vue/dist/portal-vue.umd.js:164:19)     
      at VueComponent.<anonymous> (node_modules/portal-vue/dist/portal-vue.umd.js:365:18)        
      at Array.<anonymous> (node_modules/vue/dist/vue.runtime.common.dev.js:1976:12)             
      at flushCallbacks (node_modules/vue/dist/vue.runtime.common.dev.js:1902:14)                
                                                                                                 
  console.warn                                                                                   
    [portal-vue]: Target filters_portal_38 already exists                                        
                                                                                                 
      at VueComponent.registerTarget (node_modules/portal-vue/dist/portal-vue.umd.js:164:19)     
      at VueComponent.<anonymous> (node_modules/portal-vue/dist/portal-vue.umd.js:365:18)        
      at Array.<anonymous> (node_modules/vue/dist/vue.runtime.common.dev.js:1976:12)             
      at flushCallbacks (node_modules/vue/dist/vue.runtime.common.dev.js:1902:14)

You can see this in CI as well, e.g., https://gitlab.com/gitlab-org/gitlab-ui/-/jobs/2291097645.

These warnings suggest we're doing one or both of misusing portal-vue and not cleaning up correctly in the specs.