diff --git a/docs/what_tests_can_be_run.md b/docs/what_tests_can_be_run.md index 43e1ab2c798d48910e7c79cfdd9fc3389b50b374..8dc4a6a966f278df02c2668631bf1177d8fda13d 100644 --- a/docs/what_tests_can_be_run.md +++ b/docs/what_tests_can_be_run.md @@ -57,7 +57,6 @@ All environment variables used by GitLab QA should be defined in [`lib/gitlab/qa | `QA_ADDITIONAL_REPOSITORY_STORAGE` |- | The name of additional, non-default storage to be used with tests tagged `repository_storage`, run via the `Test::Instance::RepositoryStorage` scenario. Note: Admin access is required to change repository storage. | No| | `QA_PRAEFECT_REPOSITORY_STORAGE` |- | The name of repository storage using Praefect. Note: Admin access is required to change repository storage. | No| | `QA_COOKIES` |- | Optionally set to "cookie1=value;cookie2=value" in order to add a cookie to every request. This can be used to set the canary cookie by setting it to "gitlab_canary=true", or to use a different cell e.g. "_gitlab_session=cell-2-please". | No| -| `QA_DEBUG` |- | Set to `true` to verbosely log page object actions. Note: if enabled be aware that sensitive data might be logged. If an input element has a QA selector with `password` in the name, data entered into the input element will be masked. If the element doesn't have `password` in its name it won't be masked. | No| | `QA_LOG_LEVEL` | `info` | Logging level to use for gitlab-qa output and qa tests output | No| | `QA_LOG_PATH` | `QA_ARTIFACTS_DIR` | Path to output debug logging to. | No| | `QA_CAN_TEST_GIT_PROTOCOL_V2` | `true` | Set to `false` to skip tests that require Git protocol v2 if your environment doesn't support it. | No| diff --git a/lib/gitlab/qa/runtime/env.rb b/lib/gitlab/qa/runtime/env.rb index 918879e4923193fa2afd953647bb6ab7383a4b2a..924f6c4858026fe964e839a9368af0a2c7eb1e88 100644 --- a/lib/gitlab/qa/runtime/env.rb +++ b/lib/gitlab/qa/runtime/env.rb @@ -107,7 +107,6 @@ module Gitlab 'QA_CAN_TEST_GIT_PROTOCOL_V2' => :qa_can_test_git_protocol_v2, 'QA_CAN_TEST_PRAEFECT' => :qa_can_test_praefect, 'QA_COOKIES' => :qa_cookie, - 'QA_DEBUG' => :qa_debug, 'QA_DOCKER_NETWORK' => :docker_network, 'QA_EXPORT_TEST_METRICS' => :qa_export_test_metrics, 'QA_GITALY_NON_CLUSTER_STORAGE' => :qa_gitaly_non_cluster_storage, @@ -199,10 +198,6 @@ module Gitlab variables.select { |k, _| ENV_VARIABLES[k].is_a?(Hash) && ENV_VARIABLES[k][:type] == :file }.values end - def debug? - enabled?(ENV.fetch('QA_DEBUG', nil), default: true) - end - def log_level env_var_value_if_defined('QA_LOG_LEVEL')&.upcase || 'INFO' end diff --git a/rubocop/cop/gitlab/dangerous_interpolation.rb b/rubocop/cop/gitlab/dangerous_interpolation.rb index 772ad04eada45a3a9c4afb7447eb5b3a2ab5f5db..7cc9d4e082b55202184c333928d1c3453f3e108b 100644 --- a/rubocop/cop/gitlab/dangerous_interpolation.rb +++ b/rubocop/cop/gitlab/dangerous_interpolation.rb @@ -38,7 +38,6 @@ module RuboCop 'QA_ADDITIONAL_REPOSITORY_STORAGE' => :qa_additional_repository_storage, 'QA_PRAEFECT_REPOSITORY_STORAGE' => :qa_praefect_repository_storage, 'QA_GITALY_NON_CLUSTER_STORAGE' => :qa_gitaly_non_cluster_storage, - 'QA_DEBUG' => :qa_debug, 'QA_CAN_TEST_ADMIN_FEATURES' => :qa_can_test_admin_features, 'QA_CAN_TEST_GIT_PROTOCOL_V2' => :qa_can_test_git_protocol_v2, 'QA_CAN_TEST_PRAEFECT' => :qa_can_test_praefect,