diff --git a/lib/gitlab/qa/component/gitaly.rb b/lib/gitlab/qa/component/gitaly.rb index b704c39d80b0d77f850c95ec83ec0fd81413cf1b..28d28e948260c4984c6f01d1643bcb22c6eb4539 100644 --- a/lib/gitlab/qa/component/gitaly.rb +++ b/lib/gitlab/qa/component/gitaly.rb @@ -58,6 +58,11 @@ module Gitlab commands.each { |command| docker.exec(name, command) } end + def get_reconfigure_log_file_from_artefact + all_reconfigure_log_file = Dir["#{Runtime::Env.host_artifacts_dir}/*reconfigure.log"].sort_by { |f| File.mtime(f) } + all_reconfigure_log_file.last + end + def gitaly_omnibus_configuration <<~OMNIBUS #{GitalyCluster.disable_other_omnibus_services} @@ -68,15 +73,13 @@ module Gitlab 'listen_addr': '0.0.0.0:#{gitaly_port}', 'prometheus_listen_addr': '0.0.0.0:9236', 'auth_token': 'PRAEFECT_INTERNAL_TOKEN', - 'transactions': {'enabled': #{Runtime::Env.qa_gitaly_transactions_enabled?}} - } + 'transactions': {'enabled': #{Runtime::Env.qa_gitaly_transactions_enabled?}}, + 'storage': [ + { name: '#{name}', path: '/var/opt/gitlab/git-data' } + ], + }; gitlab_shell['secret_token'] = 'GITLAB_SHELL_SECRET_TOKEN'; gitlab_rails['internal_api_url'] = 'http://#{cluster_config.gitlab_name}.#{cluster_config.network}'; - git_data_dirs({ - '#{name}' => { - 'path' => '/var/opt/gitlab/git-data' - } - }); OMNIBUS end end diff --git a/lib/gitlab/qa/scenario/test/instance/repository_storage.rb b/lib/gitlab/qa/scenario/test/instance/repository_storage.rb index 6ac43ae1bcfafcdd0fed6f2c50f25818b4e3dd8f..761180cd550fc8b0d4e646bcbf4258c2e83cbc86 100644 --- a/lib/gitlab/qa/scenario/test/instance/repository_storage.rb +++ b/lib/gitlab/qa/scenario/test/instance/repository_storage.rb @@ -53,12 +53,10 @@ module Gitlab 'gitaly_token' => 'PRAEFECT_EXTERNAL_TOKEN' }, 'gitaly' => { - 'gitaly_address' => 'tcp://gitlab.test:8075', - 'path' => '/var/opt/gitlab/git-data/gitaly' + 'gitaly_address' => 'tcp://gitlab.test:8075' }, 'secondary' => { - 'gitaly_address' => 'tcp://gitlab.test:8075', - 'path' => '/var/opt/gitlab/git-data/secondary' + 'gitaly_address' => 'tcp://gitlab.test:8075' } }); gitaly['enable'] = true; diff --git a/lib/gitlab/qa/scenario/test/integration/mtls.rb b/lib/gitlab/qa/scenario/test/integration/mtls.rb index 45a9a81890e2e3593721c8c106a8867e82d8e6b9..2bb3a95dad37f4ba9e9637c8eaf027adf0298f94 100644 --- a/lib/gitlab/qa/scenario/test/integration/mtls.rb +++ b/lib/gitlab/qa/scenario/test/integration/mtls.rb @@ -92,14 +92,8 @@ module Gitlab key_path: '/etc/gitlab/ssl/gitaly.test.key', }, storage: [ - { - name: 'default', - path: '/var/opt/gitlab/git-data/repositories', - }, - { - name: 'storage1', - path: '/mnt/gitlab/git-data/repositories', - }, + { name: 'default', path: '/var/opt/gitlab/git-data/storage/default' }, + { name: 'storage1', path: '/var/opt/gitlab/git-data/storage/storage1' } ], }; postgresql['enable'] = false; @@ -111,6 +105,7 @@ module Gitlab gitlab_exporter['enable'] = false; alertmanager['enable'] = false; prometheus['enable'] = false; + gitlab_kas['enable'] = false; gitlab_rails['rake_cache_clear'] = false; gitlab_rails['auto_migrate'] = false; @@ -118,11 +113,6 @@ module Gitlab gitlab_shell['secret_token'] = 'shellsecret'; gitlab_rails['internal_api_url'] = 'https://#{@gitlab_name}.#{@network}'; - - git_data_dirs({ - 'default' => { 'path' => '/var/opt/gitlab/git-data' }, - 'storage1' => { 'path' => '/mnt/gitlab/git-data' }, - }) OMNIBUS end end diff --git a/lib/gitlab/qa/scenario/test/integration/praefect.rb b/lib/gitlab/qa/scenario/test/integration/praefect.rb index fb95c0b23a705afc84c80cab21c3e96252f8241f..f886a1504c90dd20eeb63436f90d7de3732a4568 100644 --- a/lib/gitlab/qa/scenario/test/integration/praefect.rb +++ b/lib/gitlab/qa/scenario/test/integration/praefect.rb @@ -25,8 +25,7 @@ module Gitlab 'gitaly_token' => 'PRAEFECT_EXTERNAL_TOKEN' }, 'gitaly' => { - 'gitaly_address' => 'tcp://#{config.gitlab_name}.#{config.network}:8075', - 'path' => '/var/opt/gitlab/git-data' + 'gitaly_address' => 'tcp://#{config.gitlab_name}.#{config.network}:8075' } }); gitaly['enable'] = true; diff --git a/spec/gitlab/qa/runtime/omnibus_configuration_spec.rb b/spec/gitlab/qa/runtime/omnibus_configuration_spec.rb index b761200b4fb64f8c812702f647abedbc029635c1..f380f606d22c46ec6262ed1d6a7ef46f46612bdd 100644 --- a/spec/gitlab/qa/runtime/omnibus_configuration_spec.rb +++ b/spec/gitlab/qa/runtime/omnibus_configuration_spec.rb @@ -179,8 +179,13 @@ module Gitlab::QA::Runtime it 'method invocations' do omnibusConfiguration.<< <<~OMNIBUS git_data_dirs({ - 'default' => '/test/default', - 'alternative' => '/test/alternative' + 'default' => { + 'gitaly_address' => 'tcp://gitlab.test:8075', + }, + 'alternative' => { + 'gitaly_address' => 'tcp://gitlab.test:8075', + 'gitaly_token' => 'PRAEFECT_EXTERNAL_TOKEN' + } }) OMNIBUS