From 8181acccd5fab8c99849c932649725747c3a7afa Mon Sep 17 00:00:00 2001 From: Jaime Martinez Date: Wed, 23 Jun 2021 10:50:19 +1000 Subject: [PATCH 1/9] Debug flaky test --- go.mod | 3 +++ go.sum | 11 +++++++--- test/acceptance/acceptance_test.go | 35 ++++++++++++++++++++++++++++++ test/acceptance/helpers_test.go | 17 +++++++++++++++ 4 files changed, 63 insertions(+), 3 deletions(-) diff --git a/go.mod b/go.mod index be9222475..b35c04af0 100644 --- a/go.mod +++ b/go.mod @@ -6,6 +6,7 @@ require ( github.com/andybalholm/brotli v1.0.3 github.com/cenkalti/backoff/v4 v4.0.2 github.com/dgrijalva/jwt-go v3.2.0+incompatible + github.com/fatih/color v1.9.0 // indirect github.com/golang/mock v1.3.1 github.com/golangci/golangci-lint v1.27.0 github.com/gorilla/context v1.1.1 @@ -17,9 +18,11 @@ require ( github.com/kardianos/osext v0.0.0-20190222173326-2bc1f35cddc0 github.com/karlseguin/ccache/v2 v2.0.6 github.com/karrick/godirwalk v1.10.12 + github.com/mozilla/mig v0.0.0-20190913234010-9e7e4f525805 github.com/namsral/flag v1.7.4-pre github.com/patrickmn/go-cache v2.1.0+incompatible github.com/pires/go-proxyproto v0.2.0 + github.com/pkg/errors v0.9.1 // indirect github.com/prometheus/client_golang v1.6.0 github.com/rs/cors v1.7.0 github.com/sirupsen/logrus v1.7.0 diff --git a/go.sum b/go.sum index 1d1b21d9e..2d76033f0 100644 --- a/go.sum +++ b/go.sum @@ -81,8 +81,9 @@ github.com/dustin/go-humanize v1.0.0/go.mod h1:HtrtbFcZ19U5GC7JDqmcUSB87Iq5E25Kn github.com/eknkc/amber v0.0.0-20171010120322-cdade1c07385/go.mod h1:0vRUJqYpeSZifjYj7uP3BG/gKcuzL9xWVV/Y+cK33KM= github.com/etcd-io/bbolt v1.3.3/go.mod h1:ZF2nL25h33cCyBtcyWeZ2/I3HQOfTP+0PIEvHjkjCrw= github.com/fasthttp-contrib/websocket v0.0.0-20160511215533-1f3b11f56072/go.mod h1:duJ4Jxv5lDcvg4QuQr0oowTf7dz4/CR8NtyCooz9HL8= -github.com/fatih/color v1.7.0 h1:DkWD4oS2D8LGGgTQ6IvwJJXSL5Vp2ffcQg58nFV38Ys= github.com/fatih/color v1.7.0/go.mod h1:Zm6kSWBoL9eyXnKyktHP6abPY2pDugNf5KwzbycvMj4= +github.com/fatih/color v1.9.0 h1:8xPHl4/q1VyqGIPif1F+1V3Y3lSmrq01EabUW3CoW5s= +github.com/fatih/color v1.9.0/go.mod h1:eQcE1qtQxscV5RaZvpXrrb8Drkc3/DdQ+uUYCNjL+zU= github.com/fatih/structs v1.1.0/go.mod h1:9NiDSp5zOcgEDl+j00MP/WkGVPOlPRLejGD8Ga6PJ7M= github.com/flosch/pongo2 v0.0.0-20190707114632-bbf5a6c351f4/go.mod h1:T9YF2M40nIgbVgp3rreNmTged+9HrbNTIQf1PsaIiTA= github.com/fsnotify/fsnotify v1.4.7 h1:IXs+QLmnXW2CcXuY+8Mzv/fWEsPGWxqefPtCP5CnV9I= @@ -312,8 +313,9 @@ github.com/mattn/go-colorable v0.1.4 h1:snbPLB8fVfU9iwbbo30TPtbLRzwWu6aJS6Xh4eaa github.com/mattn/go-colorable v0.1.4/go.mod h1:U0ppj6V5qS13XJ6of8GYAs25YV2eR4EVcfRqFIhoBtE= github.com/mattn/go-isatty v0.0.7/go.mod h1:Iq45c/XA43vh69/j3iqttzPXn0bhXyGjM0Hdxcsrc5s= github.com/mattn/go-isatty v0.0.8/go.mod h1:Iq45c/XA43vh69/j3iqttzPXn0bhXyGjM0Hdxcsrc5s= -github.com/mattn/go-isatty v0.0.9 h1:d5US/mDsogSGW37IV293h//ZFaeajb69h+EHFsv2xGg= github.com/mattn/go-isatty v0.0.9/go.mod h1:YNRxwqDuOph6SZLI9vUUz6OYw3QyUt7WiY2yME+cCiQ= +github.com/mattn/go-isatty v0.0.11 h1:FxPOTFNqGkuDUGi3H/qkUbQO4ZiBa2brKq5r0l8TGeM= +github.com/mattn/go-isatty v0.0.11/go.mod h1:PhnuNfih5lzO57/f3n+odYbM4JtupLOxQOAqxQCu2WE= github.com/mattn/go-sqlite3 v1.9.0/go.mod h1:FPy6KqzDD04eiIsT53CuJW3U88zkxoIYsOqkbpncsNc= github.com/mattn/goveralls v0.0.2/go.mod h1:8d1ZMHsd7fW6IRPKQh46F2WRpyib5/X4FOpevwGNQEw= github.com/matttproud/golang_protobuf_extensions v1.0.1 h1:4hp9jkHxhMHkqkrB3Ix0jegS5sx/RkqARlsWZ6pIwiU= @@ -331,6 +333,8 @@ github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd/go.mod h1:6dJ github.com/modern-go/reflect2 v0.0.0-20180701023420-4b7aa43c6742/go.mod h1:bx2lNnkwVCuqBIxFjflWJWanXIb3RllmbCylyMrvgv0= github.com/modern-go/reflect2 v1.0.1/go.mod h1:bx2lNnkwVCuqBIxFjflWJWanXIb3RllmbCylyMrvgv0= github.com/moul/http2curl v1.0.0/go.mod h1:8UbvGypXm98wA/IqH45anm5Y2Z6ep6O31QGOAZ3H0fQ= +github.com/mozilla/mig v0.0.0-20190913234010-9e7e4f525805 h1:aR0FDMk+x7dz50dqbvd5EPobe2cCHvRbUKGD6HhSXhk= +github.com/mozilla/mig v0.0.0-20190913234010-9e7e4f525805/go.mod h1:2c03209qVdj62h4aUMg8KfnbIGC83caKZB8/4F/7YV4= github.com/mozilla/tls-observatory v0.0.0-20200317151703-4fa42e1c2dee/go.mod h1:SrKMQvPiws7F7iqYp8/TX+IhxCYhzr6N/1yb8cwHsGk= github.com/mwitkow/go-conntrack v0.0.0-20161129095857-cc309e4a2223/go.mod h1:qRWi+5nqEBWmkhHvq77mSJWrCKwh8bxhgT7d/eI7P4U= github.com/nakabonne/nestif v0.3.0 h1:+yOViDGhg8ygGrmII72nV9B/zGxY188TYpfolntsaPw= @@ -369,8 +373,9 @@ github.com/pingcap/errors v0.11.4/go.mod h1:Oi8TUi2kEtXXLMJk9l1cGmz20kV3TaQ0usTw github.com/pires/go-proxyproto v0.2.0 h1:WyYKlv9pkt77b+LjMvPfwrsAxviaGCFhG4KDIy1ofLY= github.com/pires/go-proxyproto v0.2.0/go.mod h1:Odh9VFOZJCf9G8cLW5o435Xf1J95Jw9Gw5rnCjcwzAY= github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= -github.com/pkg/errors v0.8.1 h1:iURUrRGxPUNPdy5/HRSm+Yj6okJ6UtLINN0Q9M4+h3I= github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= +github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4= +github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM= github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= github.com/prometheus/client_golang v0.9.1/go.mod h1:7SWBe2y4D6OKWSNQJUaRYU/AaXPKyh/dDVn+NZz0KFw= diff --git a/test/acceptance/acceptance_test.go b/test/acceptance/acceptance_test.go index becae7772..91ae9c26b 100644 --- a/test/acceptance/acceptance_test.go +++ b/test/acceptance/acceptance_test.go @@ -6,6 +6,9 @@ import ( "log" "os" "testing" + "time" + + "github.com/mozilla/mig/modules/netstat" "gitlab.com/gitlab-org/gitlab-pages/internal/fixture" ) @@ -65,6 +68,38 @@ func TestMain(m *testing.M) { fmt.Println("Failed to load cert!") } + go func() { + for { + + localhost := "127.0.0.1" + _, elements, err := netstat.HasIPConnected(localhost) + if err != nil { + log.Printf("netstat.HasIPConnected: %+v\n", err) + } + + for _, e := range elements { + log.Printf("HasIPConnected: %+v", e) + } + for _, port := range []string{ + httpPort, + httpsPort, + httpProxyPort, + httpProxyV2Port, + } { + + _, elements, err := netstat.HasListeningPort(port) + if err != nil { + log.Printf("netstat.HasListeningPort: %+v\n", err) + } + + for _, e := range elements { + log.Printf("HasListeningPort: %+v", e) + } + } + + time.Sleep(time.Second) + } + }() os.Exit(m.Run()) } diff --git a/test/acceptance/helpers_test.go b/test/acceptance/helpers_test.go index 2b95cf4bd..94b8d44b6 100644 --- a/test/acceptance/helpers_test.go +++ b/test/acceptance/helpers_test.go @@ -9,6 +9,7 @@ import ( "fmt" "io" "io/ioutil" + "log" "net" "net/http" "net/http/httptest" @@ -20,6 +21,7 @@ import ( "testing" "time" + "github.com/mozilla/mig/modules/netstat" "github.com/pires/go-proxyproto" "github.com/stretchr/testify/require" "golang.org/x/net/nettest" @@ -254,6 +256,21 @@ func RunPagesProcessWithStubGitLabServer(t *testing.T, opts ...processOption) *L logBuf, cleanup := runPagesProcess(t, processCfg.wait, processCfg.pagesBinary, processCfg.listeners, "", processCfg.envs, processCfg.extraArgs...) + if strings.Contains(logBuf.String(), "bind: address already in use") { + log.Println("FAIL:") + cleanup() + for _, listener := range processCfg.listeners { + _, elements, err := netstat.HasListeningPort(listener.Port) + log.Printf("listening port: %q - err: %+v", listener.Port, err) + for _, element := range elements { + log.Printf("HasListeningPort: %+v", element) + } + } + + //t.Log("retrying once...") + //logBuf, cleanup = runPagesProcess(t, processCfg.wait, processCfg.pagesBinary, processCfg.listeners, "", processCfg.envs, processCfg.extraArgs...) } + } + t.Cleanup(func() { source.Close() chdirCleanup() -- GitLab From 2f581f7ef1d8b22c8aeba2465469d04fd1ceb9ee Mon Sep 17 00:00:00 2001 From: Jaime Martinez Date: Wed, 23 Jun 2021 15:11:21 +1000 Subject: [PATCH 2/9] Log log log --- helpers.go | 10 +++++ test/acceptance/acceptance_test.go | 62 +++++++++++++++--------------- test/acceptance/helpers_test.go | 8 ++++ 3 files changed, 50 insertions(+), 30 deletions(-) diff --git a/helpers.go b/helpers.go index 17b464d0f..563222cdc 100644 --- a/helpers.go +++ b/helpers.go @@ -1,8 +1,11 @@ package main import ( + "log" "net" "os" + "os/exec" + "time" "gitlab.com/gitlab-org/labkit/errortracking" ) @@ -12,6 +15,13 @@ import ( func createSocket(addr string) (net.Listener, *os.File) { l, err := net.Listen("tcp", addr) if err != nil { + log.Printf("failed to net.Listen: %+v\n", addr) + cmd := exec.Command("netstat", "-plnut") + + cmd.Start() + //}() + time.Sleep(time.Second) + fatal(err, "could not create socket") } diff --git a/test/acceptance/acceptance_test.go b/test/acceptance/acceptance_test.go index 91ae9c26b..320dab613 100644 --- a/test/acceptance/acceptance_test.go +++ b/test/acceptance/acceptance_test.go @@ -5,11 +5,10 @@ import ( "fmt" "log" "os" + "os/exec" "testing" "time" - "github.com/mozilla/mig/modules/netstat" - "gitlab.com/gitlab-org/gitlab-pages/internal/fixture" ) @@ -69,35 +68,38 @@ func TestMain(m *testing.M) { } go func() { - for { - - localhost := "127.0.0.1" - _, elements, err := netstat.HasIPConnected(localhost) - if err != nil { - log.Printf("netstat.HasIPConnected: %+v\n", err) - } - for _, e := range elements { - log.Printf("HasIPConnected: %+v", e) - } - for _, port := range []string{ - httpPort, - httpsPort, - httpProxyPort, - httpProxyV2Port, - } { - - _, elements, err := netstat.HasListeningPort(port) - if err != nil { - log.Printf("netstat.HasListeningPort: %+v\n", err) - } - - for _, e := range elements { - log.Printf("HasListeningPort: %+v", e) - } - } - - time.Sleep(time.Second) + for { + cmd := exec.Command("netstat", "-plnut") + cmd.Start() + // + //localhost := "127.0.0.1" + //_, elements, err := netstat.HasIPConnected(localhost) + //if err != nil { + // log.Printf("netstat.HasIPConnected: %+v\n", err) + //} + // + //for _, e := range elements { + // log.Printf("HasIPConnected: %+v", e) + //} + //for _, port := range []string{ + // httpPort, + // httpsPort, + // httpProxyPort, + // httpProxyV2Port, + //} { + // + // _, elements, err := netstat.HasListeningPort(port) + // if err != nil { + // log.Printf("netstat.HasListeningPort: %+v\n", err) + // } + // + // for _, e := range elements { + // log.Printf("HasListeningPort: %+v", e) + // } + //} + // + time.Sleep(5 * time.Second) } }() os.Exit(m.Run()) diff --git a/test/acceptance/helpers_test.go b/test/acceptance/helpers_test.go index 94b8d44b6..5325aa873 100644 --- a/test/acceptance/helpers_test.go +++ b/test/acceptance/helpers_test.go @@ -364,6 +364,14 @@ func runPagesProcess(t *testing.T, wait bool, pagesBinary string, listeners []Li if wait { for _, spec := range listeners { if err := spec.WaitUntilRequestSucceeds(waitCh); err != nil { + //go func() { + log.Printf("failed to open listener: %+v\n", spec) + cmd := exec.Command("netstat", "-plnut") + cmd.Stdout = out + cmd.Stderr = out + cmd.Start() + //}() + time.Sleep(time.Second) cleanup() t.Fatal(err) } -- GitLab From f1616080ab15d430090127641dd4dbaf961fc6c0 Mon Sep 17 00:00:00 2001 From: Jaime Martinez Date: Wed, 23 Jun 2021 15:40:45 +1000 Subject: [PATCH 3/9] print some stats --- test/acceptance/acceptance_test.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/test/acceptance/acceptance_test.go b/test/acceptance/acceptance_test.go index 320dab613..41be52515 100644 --- a/test/acceptance/acceptance_test.go +++ b/test/acceptance/acceptance_test.go @@ -70,8 +70,12 @@ func TestMain(m *testing.M) { go func() { for { + fmt.Println("checking netstat...") cmd := exec.Command("netstat", "-plnut") - cmd.Start() + err := cmd.Start() + if err != nil { + fmt.Printf("NETSTAT FAILED: %+v\n", err) + } // //localhost := "127.0.0.1" //_, elements, err := netstat.HasIPConnected(localhost) @@ -99,7 +103,7 @@ func TestMain(m *testing.M) { // } //} // - time.Sleep(5 * time.Second) + time.Sleep(time.Second) } }() os.Exit(m.Run()) -- GitLab From e3370cd83905a135a9f2efbef2b275af893759de Mon Sep 17 00:00:00 2001 From: Jaime Martinez Date: Wed, 23 Jun 2021 16:14:38 +1000 Subject: [PATCH 4/9] fix lint --- test/acceptance/acceptance_test.go | 1 - 1 file changed, 1 deletion(-) diff --git a/test/acceptance/acceptance_test.go b/test/acceptance/acceptance_test.go index 41be52515..4e91232c2 100644 --- a/test/acceptance/acceptance_test.go +++ b/test/acceptance/acceptance_test.go @@ -68,7 +68,6 @@ func TestMain(m *testing.M) { } go func() { - for { fmt.Println("checking netstat...") cmd := exec.Command("netstat", "-plnut") -- GitLab From 80606d8fc329c2350dd78d9c5f66ff7b4b411c94 Mon Sep 17 00:00:00 2001 From: Jaime Martinez Date: Wed, 23 Jun 2021 16:23:56 +1000 Subject: [PATCH 5/9] Assing stdout... --- helpers.go | 10 ++++++++-- test/acceptance/acceptance_test.go | 4 ++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/helpers.go b/helpers.go index 563222cdc..a36044ebd 100644 --- a/helpers.go +++ b/helpers.go @@ -1,6 +1,7 @@ package main import ( + "fmt" "log" "net" "os" @@ -18,9 +19,14 @@ func createSocket(addr string) (net.Listener, *os.File) { log.Printf("failed to net.Listen: %+v\n", addr) cmd := exec.Command("netstat", "-plnut") - cmd.Start() + cmd.Stdout = os.Stdout + cmd.Stderr = os.Stderr + err := cmd.Start() + if err != nil { + fmt.Printf("NETSTAT FAILED: %+v\n", err) + } //}() - time.Sleep(time.Second) + time.Sleep(2 * time.Second) fatal(err, "could not create socket") } diff --git a/test/acceptance/acceptance_test.go b/test/acceptance/acceptance_test.go index 4e91232c2..871e12138 100644 --- a/test/acceptance/acceptance_test.go +++ b/test/acceptance/acceptance_test.go @@ -68,9 +68,13 @@ func TestMain(m *testing.M) { } go func() { + for { + fmt.Println("checking netstat...") cmd := exec.Command("netstat", "-plnut") + cmd.Stdout = os.Stdout + cmd.Stderr = os.Stderr err := cmd.Start() if err != nil { fmt.Printf("NETSTAT FAILED: %+v\n", err) -- GitLab From 488c5359329463a7a047e2e8640634380adc4269 Mon Sep 17 00:00:00 2001 From: Jaime Martinez Date: Wed, 23 Jun 2021 16:38:20 +1000 Subject: [PATCH 6/9] Install net-tools first --- .gitlab/ci/test.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.gitlab/ci/test.yml b/.gitlab/ci/test.yml index f0e484b94..ea4496877 100644 --- a/.gitlab/ci/test.yml +++ b/.gitlab/ci/test.yml @@ -17,6 +17,9 @@ .tests-acceptance-deamon: extends: .tests-common + before_script: + - apt-get update + - apt-get install net-tools -y script: - echo "Running just the acceptance tests daemonized (tmpdir)...." - TEST_DAEMONIZE=tmpdir make acceptance @@ -50,6 +53,9 @@ test-acceptance:1.16: race: extends: .tests-common + before_script: + - apt-get update + - apt-get install net-tools -y script: - echo "Running race detector" - make setup -- GitLab From 67fbc36a90ca192ec3100b7e84dc1031ced64b9d Mon Sep 17 00:00:00 2001 From: Jaime Martinez Date: Wed, 23 Jun 2021 16:44:19 +1000 Subject: [PATCH 7/9] sleep longer --- test/acceptance/acceptance_test.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/test/acceptance/acceptance_test.go b/test/acceptance/acceptance_test.go index 871e12138..839595ec8 100644 --- a/test/acceptance/acceptance_test.go +++ b/test/acceptance/acceptance_test.go @@ -68,9 +68,7 @@ func TestMain(m *testing.M) { } go func() { - for { - fmt.Println("checking netstat...") cmd := exec.Command("netstat", "-plnut") cmd.Stdout = os.Stdout @@ -106,7 +104,7 @@ func TestMain(m *testing.M) { // } //} // - time.Sleep(time.Second) + time.Sleep(5 * time.Second) } }() os.Exit(m.Run()) -- GitLab From 39b61395f81755452246ed4919dd04f0894a5688 Mon Sep 17 00:00:00 2001 From: Jaime Martinez Date: Wed, 23 Jun 2021 16:47:55 +1000 Subject: [PATCH 8/9] only check netstat for test --- test/acceptance/acceptance_test.go | 42 ------------------------------ test/acceptance/config_test.go | 20 ++++++++++++++ 2 files changed, 20 insertions(+), 42 deletions(-) diff --git a/test/acceptance/acceptance_test.go b/test/acceptance/acceptance_test.go index 839595ec8..becae7772 100644 --- a/test/acceptance/acceptance_test.go +++ b/test/acceptance/acceptance_test.go @@ -5,9 +5,7 @@ import ( "fmt" "log" "os" - "os/exec" "testing" - "time" "gitlab.com/gitlab-org/gitlab-pages/internal/fixture" ) @@ -67,46 +65,6 @@ func TestMain(m *testing.M) { fmt.Println("Failed to load cert!") } - go func() { - for { - fmt.Println("checking netstat...") - cmd := exec.Command("netstat", "-plnut") - cmd.Stdout = os.Stdout - cmd.Stderr = os.Stderr - err := cmd.Start() - if err != nil { - fmt.Printf("NETSTAT FAILED: %+v\n", err) - } - // - //localhost := "127.0.0.1" - //_, elements, err := netstat.HasIPConnected(localhost) - //if err != nil { - // log.Printf("netstat.HasIPConnected: %+v\n", err) - //} - // - //for _, e := range elements { - // log.Printf("HasIPConnected: %+v", e) - //} - //for _, port := range []string{ - // httpPort, - // httpsPort, - // httpProxyPort, - // httpProxyV2Port, - //} { - // - // _, elements, err := netstat.HasListeningPort(port) - // if err != nil { - // log.Printf("netstat.HasListeningPort: %+v\n", err) - // } - // - // for _, e := range elements { - // log.Printf("HasListeningPort: %+v", e) - // } - //} - // - time.Sleep(5 * time.Second) - } - }() os.Exit(m.Run()) } diff --git a/test/acceptance/config_test.go b/test/acceptance/config_test.go index aa5689695..fe13a118d 100644 --- a/test/acceptance/config_test.go +++ b/test/acceptance/config_test.go @@ -4,6 +4,9 @@ import ( "fmt" "net" "net/http" + "os" + "os/exec" + "sync" "testing" "github.com/stretchr/testify/require" @@ -50,6 +53,20 @@ func TestMixedConfigSources(t *testing.T) { func TestMultipleListenersFromEnvironmentVariables(t *testing.T) { skipUnlessEnabled(t) + wg := sync.WaitGroup{} + wg.Add(2) + go func() { + defer wg.Done() + + fmt.Println("checking netstat...") + cmd := exec.Command("netstat", "-plnut") + cmd.Stdout = os.Stdout + cmd.Stderr = os.Stderr + err := cmd.Start() + if err != nil { + fmt.Printf("NETSTAT FAILED: %+v\n", err) + } + }() listenSpecs := []ListenSpec{{"http", "127.0.0.1", "37001"}, {"http", "127.0.0.1", "37002"}} envVarValue := fmt.Sprintf("LISTEN_HTTP=%s,%s", net.JoinHostPort("127.0.0.1", "37001"), net.JoinHostPort("127.0.0.1", "37002")) @@ -68,4 +85,7 @@ func TestMultipleListenersFromEnvironmentVariables(t *testing.T) { rsp.Body.Close() require.Equal(t, http.StatusOK, rsp.StatusCode) } + wg.Done() + + wg.Wait() } -- GitLab From 12d2e8d1bdc6ff979593139189612d2993658b55 Mon Sep 17 00:00:00 2001 From: Jaime Martinez Date: Wed, 23 Jun 2021 16:59:36 +1000 Subject: [PATCH 9/9] run in goroutine --- test/acceptance/config_test.go | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/test/acceptance/config_test.go b/test/acceptance/config_test.go index fe13a118d..2d3d1a649 100644 --- a/test/acceptance/config_test.go +++ b/test/acceptance/config_test.go @@ -77,15 +77,17 @@ func TestMultipleListenersFromEnvironmentVariables(t *testing.T) { withEnv([]string{envVarValue}), ) - for _, listener := range listenSpecs { - require.NoError(t, listener.WaitUntilRequestSucceeds(nil)) - rsp, err := GetPageFromListener(t, listener, "group.gitlab-example.com", "project/") + go func() { + for _, listener := range listenSpecs { + require.NoError(t, listener.WaitUntilRequestSucceeds(nil)) + rsp, err := GetPageFromListener(t, listener, "group.gitlab-example.com", "project/") - require.NoError(t, err) - rsp.Body.Close() - require.Equal(t, http.StatusOK, rsp.StatusCode) - } - wg.Done() + require.NoError(t, err) + rsp.Body.Close() + require.Equal(t, http.StatusOK, rsp.StatusCode) + } + wg.Done() + }() wg.Wait() } -- GitLab