From a34b78ab2b93080ae498ded63c61f7360dd2504a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Coutable?= Date: Wed, 12 Jun 2019 18:45:45 +0200 Subject: [PATCH 1/4] Scope the bug label MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Rémy Coutable --- .gitlab/insights.yml | 4 ++-- .../javascripts/application/query_strings.coffee | 8 ++++---- .../application/time_to_close_bugs.coffee | 10 +++++----- lib/gitlab_insights.rb | 2 +- .../finders/time_to_close_issues_finder_spec.rb | 14 +++++++------- 5 files changed, 19 insertions(+), 19 deletions(-) diff --git a/.gitlab/insights.yml b/.gitlab/insights.yml index 11c5d16..429284a 100644 --- a/.gitlab/insights.yml +++ b/.gitlab/insights.yml @@ -6,7 +6,7 @@ issues: query: issuable_type: issue filter_labels: - - bug + - "type::bug" collection_labels: - P1 - P2 @@ -19,7 +19,7 @@ issues: query: issuable_type: issue filter_labels: - - bug + - "type::bug" collection_labels: - S1 - S2 diff --git a/app/assets/javascripts/application/query_strings.coffee b/app/assets/javascripts/application/query_strings.coffee index 465c2dc..5689850 100644 --- a/app/assets/javascripts/application/query_strings.coffee +++ b/app/assets/javascripts/application/query_strings.coffee @@ -4,14 +4,14 @@ Teams: '["Manage", "Plan", "Create", "Package", "Serverless", "Fulfillment", "Release", "Verify", "Configure", "Monitor", "Secure", "Distribution", "Gitaly", "Geo", "Quality", "security", "gitter", "frontend"]', Severities: '["S4", "S3", "S2", "S1"]', Priorities: '["P4", "P3", "P2", "P1"]', - Bugs: '["bug"]', - BugsPastSlo: '["bug", "missed-SLO"]', - CustomerBugsPastSlo: '["bug", "customer", "missed-SLO"]', + Bugs: '["type::bug"]', + BugsPastSlo: '["type::bug", "missed-SLO"]', + CustomerBugsPastSlo: '["type::bug", "customer", "missed-SLO"]', FeatureProposals: '["feature"]', Regression: '["regression"]', RegressionMilestones: '["regression:11.0","regression:11.1","regression:11.2","regression:11.3","regression:11.4","regression:11.5", "regression:11.6", "regression:11.7", "regression:11.8", "regression:11.9", "regression:11.10", "regression:11.11", "regression:12.0"]', MissedDeliverable: '["missed-deliverable"]', MissedDeliverableMilestones: '["missed:11.0","missed:11.1","missed:11.2","missed:11.3","missed:11.4","missed:11.5", "missed:11.6", "missed:11.7", "missed:11.8", "missed:11.9", "missed:11.10", "missed:11.11", "missed:12.0"]' - MergeRequestCategories: '["Community contribution","security","bug","feature","backstage"]' + MergeRequestCategories: '["Community contribution","security","type::bug","feature","backstage"]' TeamMRWeeks: 12 TeamMRMonths: 24 diff --git a/app/assets/javascripts/application/time_to_close_bugs.coffee b/app/assets/javascripts/application/time_to_close_bugs.coffee index b367f04..8258993 100644 --- a/app/assets/javascripts/application/time_to_close_bugs.coffee +++ b/app/assets/javascripts/application/time_to_close_bugs.coffee @@ -1,7 +1,7 @@ TimeToCloseBugsChart = (element) -> query = @queries.ScopedQuery(@queries.TimeToCloseIssues( 'Closed', - '["bug"]', + '["type::bug"]', @query_strings.TeamMRMonths )) @charts.ComboBarLineChart(element, query.query_string, query.view_string) @@ -9,7 +9,7 @@ TimeToCloseBugsChart = (element) -> TimeToCloseS1BugsChart = (element) -> query = @queries.ScopedQuery(@queries.TimeToCloseIssues( 'Closed', - '["bug", "S1"]', + '["type::bug", "S1"]', @query_strings.TeamMRMonths )) @charts.ComboBarLineChart(element, query.query_string, query.view_string) @@ -17,7 +17,7 @@ TimeToCloseS1BugsChart = (element) -> TimeToCloseS2BugsChart = (element) -> query = @queries.ScopedQuery(@queries.TimeToCloseIssues( 'Closed', - '["bug", "S2"]', + '["type::bug", "S2"]', @query_strings.TeamMRMonths )) @charts.ComboBarLineChart(element, query.query_string, query.view_string) @@ -25,7 +25,7 @@ TimeToCloseS2BugsChart = (element) -> TimeToCloseS1CustomerBugsChart = (element) -> query = @queries.ScopedQuery(@queries.TimeToCloseIssues( 'Closed', - '["bug", "S1", "customer"]', + '["type::bug", "S1", "customer"]', @query_strings.TeamMRMonths )) @charts.ComboBarLineChart(element, query.query_string, query.view_string) @@ -33,7 +33,7 @@ TimeToCloseS1CustomerBugsChart = (element) -> TimeToCloseS2CustomerBugsChart = (element) -> query = @queries.ScopedQuery(@queries.TimeToCloseIssues( 'Closed', - '["bug", "S2", "customer"]', + '["type::bug", "S2", "customer"]', @query_strings.TeamMRMonths )) @charts.ComboBarLineChart(element, query.query_string, query.view_string) diff --git a/lib/gitlab_insights.rb b/lib/gitlab_insights.rb index 70593b5..526a1c0 100644 --- a/lib/gitlab_insights.rb +++ b/lib/gitlab_insights.rb @@ -50,7 +50,7 @@ module GitlabInsights "P3" => MEDIUM_COLOR, "P4" => LOW_COLOR, "feature" => PROPOSAL_COLOR, - "bug" => BUG_COLOR, + "type::bug" => BUG_COLOR, "security" => SECURITY_COLOR, "Community contribution" => COMMUNITY_CONTRIBUTION_COLOR, "backstage" => DEFAULT_COLOR, diff --git a/spec/lib/gitlab_insights/finders/time_to_close_issues_finder_spec.rb b/spec/lib/gitlab_insights/finders/time_to_close_issues_finder_spec.rb index 7d8a266..73f5d75 100644 --- a/spec/lib/gitlab_insights/finders/time_to_close_issues_finder_spec.rb +++ b/spec/lib/gitlab_insights/finders/time_to_close_issues_finder_spec.rb @@ -12,25 +12,25 @@ RSpec.describe GitlabInsights::Finders::TimeToCloseIssuesFinder do let(:group) { create(:group) } let(:project) { create(:project, group: group) } let!(:issue1) { create(single_scope, - labels: ['bug','s1', 'customer'], + labels: ['type::bug','s1', 'customer'], state: 'closed', created_at: Date.new(2018,6,1), closed_at: Date.new(2018,6,10), project: project) } let!(:issue2) { create(single_scope, - labels: ['bug','s1', 'customer'], + labels: ['type::bug','s1', 'customer'], state: 'closed', created_at: Date.new(2018,6,1), closed_at: Date.new(2018,6,20), project: project) } let!(:issue3) { create(single_scope, - labels: ['bug','s1'], + labels: ['type::bug','s1'], state: 'closed', created_at: Date.new(2018,6,1), closed_at: Date.new(2018,6,30), project: project) } let!(:issue4) { create(single_scope, - labels: ['bug','s2'], + labels: ['type::bug','s2'], state: 'closed', created_at: Date.new(2018,6,1), closed_at: Date.new(2018,6,10), @@ -56,7 +56,7 @@ RSpec.describe GitlabInsights::Finders::TimeToCloseIssuesFinder do }.with_indifferent_access, ] - actual = subject.find({ filter_labels: ['bug']}) + actual = subject.find({ filter_labels: ['type::bug']}) expect(actual).to be_a(Array) @@ -83,7 +83,7 @@ RSpec.describe GitlabInsights::Finders::TimeToCloseIssuesFinder do }.with_indifferent_access, ] - actual = subject.find({ filter_labels: ['bug', 's1']}) + actual = subject.find({ filter_labels: ['type::bug', 's1']}) expect(actual).to be_a(Array) @@ -110,7 +110,7 @@ RSpec.describe GitlabInsights::Finders::TimeToCloseIssuesFinder do }.with_indifferent_access, ] - actual = subject.find({ filter_labels: ['bug', 's1', 'customer']}) + actual = subject.find({ filter_labels: ['type::bug', 's1', 'customer']}) expect(actual).to be_a(Array) -- GitLab From dcaff407e8db0284e9a6b6a78957a4f48575c2b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Coutable?= Date: Wed, 12 Jun 2019 18:46:16 +0200 Subject: [PATCH 2/4] Scope the feature label MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Rémy Coutable --- app/assets/javascripts/application/query_strings.coffee | 4 ++-- lib/gitlab_insights.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/assets/javascripts/application/query_strings.coffee b/app/assets/javascripts/application/query_strings.coffee index 5689850..eecee1b 100644 --- a/app/assets/javascripts/application/query_strings.coffee +++ b/app/assets/javascripts/application/query_strings.coffee @@ -7,11 +7,11 @@ Bugs: '["type::bug"]', BugsPastSlo: '["type::bug", "missed-SLO"]', CustomerBugsPastSlo: '["type::bug", "customer", "missed-SLO"]', - FeatureProposals: '["feature"]', + FeatureProposals: '["type::feature"]', Regression: '["regression"]', RegressionMilestones: '["regression:11.0","regression:11.1","regression:11.2","regression:11.3","regression:11.4","regression:11.5", "regression:11.6", "regression:11.7", "regression:11.8", "regression:11.9", "regression:11.10", "regression:11.11", "regression:12.0"]', MissedDeliverable: '["missed-deliverable"]', MissedDeliverableMilestones: '["missed:11.0","missed:11.1","missed:11.2","missed:11.3","missed:11.4","missed:11.5", "missed:11.6", "missed:11.7", "missed:11.8", "missed:11.9", "missed:11.10", "missed:11.11", "missed:12.0"]' - MergeRequestCategories: '["Community contribution","security","type::bug","feature","backstage"]' + MergeRequestCategories: '["Community contribution","security","type::bug","type::feature","backstage"]' TeamMRWeeks: 12 TeamMRMonths: 24 diff --git a/lib/gitlab_insights.rb b/lib/gitlab_insights.rb index 526a1c0..b862e80 100644 --- a/lib/gitlab_insights.rb +++ b/lib/gitlab_insights.rb @@ -49,7 +49,7 @@ module GitlabInsights "P2" => HIGH_COLOR, "P3" => MEDIUM_COLOR, "P4" => LOW_COLOR, - "feature" => PROPOSAL_COLOR, + "type::feature" => PROPOSAL_COLOR, "type::bug" => BUG_COLOR, "security" => SECURITY_COLOR, "Community contribution" => COMMUNITY_CONTRIBUTION_COLOR, -- GitLab From b0333ee8c538def7a6c3755cdbeb2affdc9af8ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Coutable?= Date: Wed, 12 Jun 2019 18:46:43 +0200 Subject: [PATCH 3/4] Scope the backstage label MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Rémy Coutable --- app/assets/javascripts/application/query_strings.coffee | 2 +- lib/gitlab_insights.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/application/query_strings.coffee b/app/assets/javascripts/application/query_strings.coffee index eecee1b..a2994dc 100644 --- a/app/assets/javascripts/application/query_strings.coffee +++ b/app/assets/javascripts/application/query_strings.coffee @@ -12,6 +12,6 @@ RegressionMilestones: '["regression:11.0","regression:11.1","regression:11.2","regression:11.3","regression:11.4","regression:11.5", "regression:11.6", "regression:11.7", "regression:11.8", "regression:11.9", "regression:11.10", "regression:11.11", "regression:12.0"]', MissedDeliverable: '["missed-deliverable"]', MissedDeliverableMilestones: '["missed:11.0","missed:11.1","missed:11.2","missed:11.3","missed:11.4","missed:11.5", "missed:11.6", "missed:11.7", "missed:11.8", "missed:11.9", "missed:11.10", "missed:11.11", "missed:12.0"]' - MergeRequestCategories: '["Community contribution","security","type::bug","type::feature","backstage"]' + MergeRequestCategories: '["Community contribution","security","type::bug","type::feature","type::backstage"]' TeamMRWeeks: 12 TeamMRMonths: 24 diff --git a/lib/gitlab_insights.rb b/lib/gitlab_insights.rb index b862e80..b114eb6 100644 --- a/lib/gitlab_insights.rb +++ b/lib/gitlab_insights.rb @@ -53,7 +53,7 @@ module GitlabInsights "type::bug" => BUG_COLOR, "security" => SECURITY_COLOR, "Community contribution" => COMMUNITY_CONTRIBUTION_COLOR, - "backstage" => DEFAULT_COLOR, + "type::backstage" => DEFAULT_COLOR, "Manage" => COLOR_SCHEME[:orange], "Plan" => COLOR_SCHEME[:green], "Create" => COLOR_SCHEME[:yellow], -- GitLab From 7a2231e74a244b1e5beeae32db012db5068e5998 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Coutable?= Date: Wed, 12 Jun 2019 18:47:34 +0200 Subject: [PATCH 4/4] Scope the security label MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Rémy Coutable --- app/assets/javascripts/application/query_strings.coffee | 4 ++-- lib/gitlab_insights.rb | 2 +- lib/gitlab_insights/resource_categorizer.rb | 2 +- spec/lib/gitlab_insights/resource_categorizer_spec.rb | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/assets/javascripts/application/query_strings.coffee b/app/assets/javascripts/application/query_strings.coffee index a2994dc..1123132 100644 --- a/app/assets/javascripts/application/query_strings.coffee +++ b/app/assets/javascripts/application/query_strings.coffee @@ -1,7 +1,7 @@ @query_strings = IssuesScope: 'Issues', MergeRequestsScope: 'MergeRequests', - Teams: '["Manage", "Plan", "Create", "Package", "Serverless", "Fulfillment", "Release", "Verify", "Configure", "Monitor", "Secure", "Distribution", "Gitaly", "Geo", "Quality", "security", "gitter", "frontend"]', + Teams: '["Manage", "Plan", "Create", "Package", "Serverless", "Fulfillment", "Release", "Verify", "Configure", "Monitor", "Secure", "Distribution", "Gitaly", "Geo", "Quality", "type::security", "gitter", "frontend"]', Severities: '["S4", "S3", "S2", "S1"]', Priorities: '["P4", "P3", "P2", "P1"]', Bugs: '["type::bug"]', @@ -12,6 +12,6 @@ RegressionMilestones: '["regression:11.0","regression:11.1","regression:11.2","regression:11.3","regression:11.4","regression:11.5", "regression:11.6", "regression:11.7", "regression:11.8", "regression:11.9", "regression:11.10", "regression:11.11", "regression:12.0"]', MissedDeliverable: '["missed-deliverable"]', MissedDeliverableMilestones: '["missed:11.0","missed:11.1","missed:11.2","missed:11.3","missed:11.4","missed:11.5", "missed:11.6", "missed:11.7", "missed:11.8", "missed:11.9", "missed:11.10", "missed:11.11", "missed:12.0"]' - MergeRequestCategories: '["Community contribution","security","type::bug","type::feature","type::backstage"]' + MergeRequestCategories: '["Community contribution","type::security","type::bug","type::feature","type::backstage"]' TeamMRWeeks: 12 TeamMRMonths: 24 diff --git a/lib/gitlab_insights.rb b/lib/gitlab_insights.rb index b114eb6..adcbbdb 100644 --- a/lib/gitlab_insights.rb +++ b/lib/gitlab_insights.rb @@ -51,7 +51,7 @@ module GitlabInsights "P4" => LOW_COLOR, "type::feature" => PROPOSAL_COLOR, "type::bug" => BUG_COLOR, - "security" => SECURITY_COLOR, + "type::security" => SECURITY_COLOR, "Community contribution" => COMMUNITY_CONTRIBUTION_COLOR, "type::backstage" => DEFAULT_COLOR, "Manage" => COLOR_SCHEME[:orange], diff --git a/lib/gitlab_insights/resource_categorizer.rb b/lib/gitlab_insights/resource_categorizer.rb index c6044c8..dff445f 100644 --- a/lib/gitlab_insights/resource_categorizer.rb +++ b/lib/gitlab_insights/resource_categorizer.rb @@ -14,7 +14,7 @@ module GitlabInsights return unless project.dev? return unless resource_type == :merge_requests - resource[:labels] << 'security' unless resource[:labels].include?('security') + resource[:labels] << 'type::security' unless resource[:labels].include?('type::security') end end end diff --git a/spec/lib/gitlab_insights/resource_categorizer_spec.rb b/spec/lib/gitlab_insights/resource_categorizer_spec.rb index 5c5e40c..d0e8b5b 100644 --- a/spec/lib/gitlab_insights/resource_categorizer_spec.rb +++ b/spec/lib/gitlab_insights/resource_categorizer_spec.rb @@ -27,9 +27,9 @@ RSpec.describe GitlabInsights::ResourceCategorizer do let(:project) { create(:project, :dev, group: group) } it 'adds the security label' do - expect(resource[:labels]).not_to include('security') + expect(resource[:labels]).not_to include('type::security') - expect(subject[:labels]).to include('security') + expect(subject[:labels]).to include('type::security') end end end -- GitLab