From e158eee9c9becd2f5beb7861f45fcf18d1a3927a Mon Sep 17 00:00:00 2001 From: Phil Hughes Date: Sun, 21 Aug 2016 10:02:44 +0100 Subject: [PATCH] Adds search box to done list on issue boards Closes #21139 --- app/assets/javascripts/boards/models/list.js.es6 | 2 +- spec/features/boards/boards_spec.rb | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/boards/models/list.js.es6 b/app/assets/javascripts/boards/models/list.js.es6 index be2b8c568a83..b8470de17e8a 100644 --- a/app/assets/javascripts/boards/models/list.js.es6 +++ b/app/assets/javascripts/boards/models/list.js.es6 @@ -59,7 +59,7 @@ class List { } canSearch () { - return this.type === 'backlog'; + return ['backlog', 'done'].indexOf(this.type) > -1; } getIssues (emptyIssues = true) { diff --git a/spec/features/boards/boards_spec.rb b/spec/features/boards/boards_spec.rb index 5d777895542c..e3c2ae64f2f8 100644 --- a/spec/features/boards/boards_spec.rb +++ b/spec/features/boards/boards_spec.rb @@ -206,6 +206,16 @@ end context 'done' do + it 'is searchable' do + page.within(find('.board:nth-child(4)')) do + find('.form-control').set 'testing' + + wait_for_vue_resource(spinner: false) + + expect(page).to have_selector('.card', count: 0) + end + end + it 'shows list of done issues' do expect(find('.board:nth-child(4)')).to have_selector('.card', count: 1) end -- GitLab