From 4bd2ae635dad58c41cac3c5a9f0120b8cf0bfc13 Mon Sep 17 00:00:00 2001 From: Alfredo Sumaran Date: Thu, 9 Jun 2016 15:19:11 -0500 Subject: [PATCH 1/2] Remove styles for :focus state on buttons --- app/assets/javascripts/application.js.coffee | 4 ---- app/assets/stylesheets/framework/buttons.scss | 7 ++----- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/app/assets/javascripts/application.js.coffee b/app/assets/javascripts/application.js.coffee index c98763d6271e..6a8bceeef6ae 100644 --- a/app/assets/javascripts/application.js.coffee +++ b/app/assets/javascripts/application.js.coffee @@ -221,10 +221,6 @@ $ -> form = btn.closest("form") new ConfirmDangerModal(form, text) - - $document.on 'click', 'button', -> - $(this).blur() - $('input[type="search"]').each -> $this = $(this) $this.attr 'value', $this.val() diff --git a/app/assets/stylesheets/framework/buttons.scss b/app/assets/stylesheets/framework/buttons.scss index 590b8f54363b..58ac4d467653 100644 --- a/app/assets/stylesheets/framework/buttons.scss +++ b/app/assets/stylesheets/framework/buttons.scss @@ -4,7 +4,6 @@ font-weight: 500; padding: $gl-vert-padding $gl-btn-padding; - &:focus, &:active { outline: none; background-color: $btn-active-gray; @@ -21,8 +20,7 @@ color: $text; border-color: $border; - &:hover, - &:focus { + &:hover { background-color: $hover-background; color: $hover-text; border-color: $hover-border;; @@ -34,8 +32,7 @@ border-color: $border-light; color: $color; - &:hover, - &:focus { + &:hover { background-color: $normal; border-color: $border-normal; color: $color; -- GitLab From 253b49974fcab655bafac1a21fab431d664202a4 Mon Sep 17 00:00:00 2001 From: Alfredo Sumaran Date: Mon, 11 Jul 2016 16:49:50 -0500 Subject: [PATCH 2/2] Add :focus style for buttons --- app/assets/stylesheets/framework/buttons.scss | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/app/assets/stylesheets/framework/buttons.scss b/app/assets/stylesheets/framework/buttons.scss index 58ac4d467653..6ace51284e17 100644 --- a/app/assets/stylesheets/framework/buttons.scss +++ b/app/assets/stylesheets/framework/buttons.scss @@ -25,6 +25,11 @@ color: $hover-text; border-color: $hover-border;; } + + &:focus { + outline: none; + border-color: darken($border, 15%); + } } @mixin btn-color($light, $border-light, $normal, $border-normal, $dark, $border-dark, $color) { @@ -46,6 +51,11 @@ border-color: $border-dark; color: $color; } + + &:focus { + outline: none; + border-color: $border-dark; + } } @mixin btn-green { -- GitLab