[go: up one dir, main page]

Skip to content

Display change that made discussion outdated in-line

As of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11584, any time new commits are pushed into an MR that directly touch lines that had diff discussions on them, these discussions are marked as outdated and get a system note with a link to the comparison between the two MR versions, and the exact line in that diff that represents that change.

This is useful for reviewers who may want to see how, exactly, their concerns ended up being addressed, before they mark the discussion as resolved, or to verify that a discussion that was resolved by the MR author was indeed addressed as expected.

However, the MR diffs page can be quite slow to load, especially when comparing two different versions (because the comparison isn't cached), and especially when the push involved a rebase or merged commit, which can result in changes being included in the diff that aren't actually relevant. (See also &340 (closed)).

I would love it if the change diff was displayed in-line, as part of the system note, potentially behind a "Toggle diff" switch, as below:

Captura_de_pantalla_2018-10-01_a_la_s__19.06.13

Captura_de_pantalla_2018-10-01_a_la_s__19.05.46

It could just be a simple static diff with a few lines of context; if I want to see more context, or comment on the change, I can follow the "version X of the diff" link.

/cc @jramsay @andr3