From af7cf57b4aa25f86cf8a0742d6eafc503986a813 Mon Sep 17 00:00:00 2001 From: Sami Hiltunen Date: Mon, 8 Apr 2024 21:35:23 +0300 Subject: [PATCH] Revert "Wait for handlers to exit when stopping gRPC server" This reverts commit 40866e974023eaac50f77f0c913baf04dd4935c9. --- internal/gitaly/server/server.go | 1 - internal/praefect/server.go | 1 - 2 files changed, 2 deletions(-) diff --git a/internal/gitaly/server/server.go b/internal/gitaly/server/server.go index bd373b87ab..fd39ec9ab1 100644 --- a/internal/gitaly/server/server.go +++ b/internal/gitaly/server/server.go @@ -187,7 +187,6 @@ func (s *GitalyServerFactory) New(external, secure bool, opts ...Option) (*grpc. grpc.KeepaliveParams(keepalive.ServerParameters{ Time: 5 * time.Minute, }), - grpc.WaitForHandlers(true), } return grpc.NewServer(serverOptions...), nil diff --git a/internal/praefect/server.go b/internal/praefect/server.go index 48cacfc2fa..f985791b1c 100644 --- a/internal/praefect/server.go +++ b/internal/praefect/server.go @@ -167,7 +167,6 @@ func NewGRPCServer( grpc.KeepaliveParams(keepalive.ServerParameters{ Time: 5 * time.Minute, }), - grpc.WaitForHandlers(true), }...) // Accept backchannel connections so that we can proxy sidechannels -- GitLab