From c71ad2a83eaf910d7dbcb650b8440d68fc08fac4 Mon Sep 17 00:00:00 2001 From: Zeger-Jan van de Weg Date: Wed, 26 Jun 2019 18:52:36 +0200 Subject: [PATCH] Remove Code Quality for Gitaly Code Quality ran on each pipeline, but wasn't enforced so led to confusion. Pipelines don't fail if it finds anything so it's not enforced either. `make verify` includes checks to create an enforced style from within our project. --- .gitlab-ci.yml | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index c2207b0ac6..5c9a0ade46 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -131,21 +131,6 @@ cover: script: - make cover -code_quality: - image: docker:stable - allow_failure: true - services: - - docker:stable-dind - script: - - export SP_VERSION=$(echo "$CI_SERVER_VERSION" | sed 's/^\([0-9]*\)\.\([0-9]*\).*/\1-\2-stable/') - - docker run - --env SOURCE_CODE="$PWD" - --volume "$PWD":/code - --volume /var/run/docker.sock:/var/run/docker.sock - "registry.gitlab.com/gitlab-org/security-products/codequality:$SP_VERSION" /code - artifacts: - paths: [gl-code-quality-report.json] - .build_image: &build_image stage: publish image: docker:latest -- GitLab