[go: up one dir, main page]

Goroutine leak for RailsRateLimitedError response

This issue is raised as an observation in gitlabnet.go code

Context

In gitlabnet.go when a 429 (Too Many Requests) response is received, the function returns early with RailsRateLimitedError{} , without response.Body.Close(), the HTTP response body remains open. The underlying HTTP transport keeps a goroutine alive to handle the connection. Since the response is never returned to the caller, it can never be properly closed.

Edited by Syed Saif Ali Alvi