bring your own Git binaries
A new issue was raised via a comment on a closed issue: copying to a new issue so it is visible to the team.
James, your commits to Gitaly above have broken the use case of supporting the use of "bring your own Git binaries" which we at KDE were utilising.
This caused significant issues with our upgrade to Gitlab 17.3 as this change in requirements is not advertised anywhere, and from what I can tell the documentation still refers to bringing your own Git as a supported scenario.
Now I have to be concerned about two different versions of Git on my system interacting badly with each other, as Git needs to be installed on the system in order to bootstrap system setup, however the actual underlying GItlab repositories should only be interacted with using the Git provided by Gitaly (and we have custom Git hooks...).
Inflaming things further your code builds Git with a non-standard binary name, gitaly-git-v2.45.
Please revert 846ab637 above and/or provide documentation on how to ensure there is no conflict. We have Git 2.46.0 installed on the system level so I am not anticipating any conflicts however this does not bring me much comfort.