Flaky test in client package from left over socket files
There appears to be a flaky test in the Gitaly client package, potentially due to improper clean up of socket files. The problem can be replicated with a large test count:
time="2019-06-24T08:09:24-07:00" level=warning msg="git path not configured. Using default path resolution" resolvedPath=/usr/local/bin/git
time="2019-06-24T08:09:24-07:00" level=warning msg="Gitaly bin directory is not configured" error="stat : no such file or directory"
--- FAIL: TestDial (0.01s)
--- FAIL: TestDial/unix_relative (0.00s)
require.go:794:
Error Trace: dial_test.go:120
Error: Received unexpected error:
rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = "transport: Error while dialing dial unix testdata/gitaly.socket: socket: too many open files"
Test: TestDial/unix_relative
Note: output truncated, remaining can be viewed in attachment test_failure.txt.