From e44b13980aac24a347f68d587a08e3aa3bf20be3 Mon Sep 17 00:00:00 2001 From: Anatoli Babenia Date: Tue, 25 Feb 2025 09:26:57 +0300 Subject: [PATCH 1/3] chore: switch to Go 1.24.0 It got `t.Chdir(dir)` https://pkg.go.dev/testing@master#T.Chdir --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 59831c0c6..cf32af740 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module gitlab.com/gitlab-org/cli -go 1.23.4 +go 1.24.0 require ( github.com/AlecAivazis/survey/v2 v2.3.7 -- GitLab From 2a05929567658721272c9460becd6b3fdf19103f Mon Sep 17 00:00:00 2001 From: Anatoli Babenia Date: Tue, 25 Feb 2025 13:30:10 +0300 Subject: [PATCH 2/3] chore: bump Go version in CI --- .gitlab-ci.yml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index e9eae1096..37279194f 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1,5 +1,6 @@ variables: - GO_VERSION: "1.23.4" + # with Go version in `go.mod`, this could be not actual + GO_VERSION: "1.24.0" GOLANGCI_LINT_VERSION: 'v1.60.1' GITLAB_ADVANCED_SAST_ENABLED: 'true' @@ -110,12 +111,6 @@ lint: run_tests: stage: test extends: .go-cache - # We currently only test on the lastest versino of Go which we also build against. - # If we need to introduce testing for future versions of compatibility reasons - # uncomment the below lines and adjust the `GO_VERSION` to included versions to test. - # parallel: - # matrix: - # - GO_VERSION: ["1.22.3"] script: # `goreleaser` also uses GITLAB_TOKEN and so we need to distinguish between # the GITLAB_TOKEN_TEST with less privilege used for testing and the GITLAB_TOKEN_RELEASE token -- GitLab From a81dbddfa5d0ce9ceacd0803d40dc30fff3fd215 Mon Sep 17 00:00:00 2001 From: Anatoli Babenia Date: Tue, 25 Feb 2025 13:50:36 +0300 Subject: [PATCH 3/3] chore: bump golangci-lint in CI to use Go 1.24 images --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 37279194f..d235c7baa 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1,7 +1,7 @@ variables: # with Go version in `go.mod`, this could be not actual GO_VERSION: "1.24.0" - GOLANGCI_LINT_VERSION: 'v1.60.1' + GOLANGCI_LINT_VERSION: 'v1.64.5' GITLAB_ADVANCED_SAST_ENABLED: 'true' # run the pipeline only on MRs, tags, and default branch -- GitLab