From 064691c73cef709256c9fe5822bafa3378be3b70 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Cunha?= Date: Fri, 23 Aug 2024 11:22:07 -0300 Subject: [PATCH 1/2] Bump upgrade stop to 17.3 --- templates/_runcheck.tpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/_runcheck.tpl b/templates/_runcheck.tpl index b1270f645f..aaec0454ff 100644 --- a/templates/_runcheck.tpl +++ b/templates/_runcheck.tpl @@ -35,8 +35,8 @@ if [ -d "${secrets_dir}" ]; then fi fi fi -MIN_VERSION=16.11 -CHART_MIN_VERSION=7.11 +MIN_VERSION=17.3 +CHART_MIN_VERSION=8.3 # Remove 'v' prefix from GitLab version if present (set in Chart.yaml appVersions) GITLAB_VERSION=${GITLAB_VERSION#v} -- GitLab From 086b03c4d55582e01cc79ae22b5626ca9b963dfc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Cunha?= Date: Fri, 23 Aug 2024 11:22:28 -0300 Subject: [PATCH 2/2] Stop requiring tests to be updated We've decided to possibly make this a BATs test to run on CI Or to simply not run it anymore, since this is already going to be automated anyway. Ref: https://gitlab.com/gitlab-org/release-tools/-/merge_requests/3325#note_2017063596 --- doc/development/upgrade_stop.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/doc/development/upgrade_stop.md b/doc/development/upgrade_stop.md index bf484876e4..33582ef360 100644 --- a/doc/development/upgrade_stop.md +++ b/doc/development/upgrade_stop.md @@ -15,5 +15,3 @@ To apply a new upgrade stop: 1. A new upgrade stop must be applied in the next minor release. For example, the 16.3 upgrade stop must be merged into 16.4. 1. Change `MIN_VERSION` and `CHART_MIN_VERSION` in `templates/_runcheck.tpl`. -1. Update the test cases in `scripts/debug/test_runcheck.sh`. -1. Confirm that the test cases pass. -- GitLab